r63912 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r63911‎ | r63912 | r63913 >
Date:16:25, 18 March 2010
Author:ialex
Status:resolved (Comments)
Tags:
Comment:
* (bug 12901) #switch no longer expands node twice
Modified paths:
  • /trunk/extensions/ParserFunctions/ParserFunctions_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ParserFunctions/ParserFunctions_body.php
——@@ -211,7 +211,6 @@
212212 # Multiple input match
213213 return trim( $frame->expand( $valueNode ) );
214214 } else {
215 - $test = trim( $frame->expand( $nameNode ) );
216215 if ( $test == $primary ) {
217216 # Found a match, return now
218217 return trim( $frame->expand( $valueNode ) );

Follow-up revisions

RevisionCommit summaryAuthorDate
r63980Per Platonides, follow-up r63912: readd the removed line and remove the other...ialex16:39, 20 March 2010

Comments

#Comment by Platonides (talk | contribs)   14:58, 20 March 2010

Discovered and patched by azatoth.

Couldn't we remove the previous $test = trim( $frame->expand( $nameNode ) ); line instead? It only seems to be used inside the else branch.

#Comment by IAlex (talk | contribs)   16:39, 20 March 2010

Done in r63980.

Status & tagging log