r63980 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r63979‎ | r63980 | r63981 >
Date:16:39, 20 March 2010
Author:ialex
Status:ok
Tags:
Comment:
Per Platonides, follow-up r63912: readd the removed line and remove the other one, since it's only used there
Modified paths:
  • /trunk/extensions/ParserFunctions/ParserFunctions_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ParserFunctions/ParserFunctions_body.php
——@@ -206,11 +206,11 @@
207207 if ( $index === '' ) {
208208 # Found "="
209209 $lastItemHadNoEquals = false;
210 - $test = trim( $frame->expand( $nameNode ) );
211210 if ( $found ) {
212211 # Multiple input match
213212 return trim( $frame->expand( $valueNode ) );
214213 } else {
 214+ $test = trim( $frame->expand( $nameNode ) );
215215 if ( $test == $primary ) {
216216 # Found a match, return now
217217 return trim( $frame->expand( $valueNode ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63912* (bug 12901) #switch no longer expands node twiceialex16:25, 18 March 2010

Status & tagging log