r63901 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63900‎ | r63901 | r63902 >
Date:05:42, 18 March 2010
Author:tstarling
Status:ok
Tags:
Comment:
Don't send hundreds of lines of useless progress messages to stdout.
Modified paths:
  • /trunk/phase3/maintenance/namespaceDupes.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/namespaceDupes.php
@@ -153,20 +153,12 @@
154154 * @param $suffix String Suffix to append to renamed articles
155155 */
156156 private function checkNamespace( $ns, $name, $fix, $suffix = '' ) {
157 - if( $ns == 0 ) {
158 - $header = "Checking interwiki prefix: \"$name\"\n";
159 - } else {
160 - $header = "Checking namespace $ns: \"$name\"\n";
161 - }
162 -
163157 $conflicts = $this->getConflicts( $ns, $name );
164158 $count = count( $conflicts );
165159 if( $count == 0 ) {
166 - $this->output( $header . "... no conflict detected!\n" );
167160 return true;
168161 }
169162
170 - $this->output( $header . "... $count conflicts detected:\n" );
171163 $ok = true;
172164 foreach( $conflicts as $row ) {
173165 $resolvable = $this->reportConflict( $row, $suffix );

Follow-up revisions

RevisionCommit summaryAuthorDate
r64049* MFT r63764, r63897, r63898, r63899, r63900, r63901, r63902. Most changes ar...tstarling00:06, 23 March 2010
r64051MFT r63764, r63897, r63898, r63899, r63900, r63901, r63902: assorted working ...tstarling01:21, 23 March 2010

Status & tagging log