r63764 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r63763‎ | r63764 | r63765 >
Date:08:11, 15 March 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 19627) Fix regression from r57867 where HTMLForm would output <element classes="foo bar"> rather than <element class="foo bar">
Modified paths:
  • /trunk/phase3/includes/HTMLForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLForm.php
——@@ -572,7 +572,7 @@
573573 if( !$hasLeftColumn ) // Avoid strange spacing when no labels exist
574574 $classes[] = 'mw-htmlform-nolabel';
575575 $attribs = array(
576 - 'classes' => implode( ' ', $classes ),
 576+ 'class' => implode( ' ', $classes ),
577577 );
578578 if ( $sectionName )
579579 $attribs['id'] = Sanitizer::escapeId( "mw-htmlform-$sectionName" );

Follow-up revisions

RevisionCommit summaryAuthorDate
r64049* MFT r63764, r63897, r63898, r63899, r63900, r63901, r63902. Most changes ar...tstarling00:06, 23 March 2010
r64051MFT r63764, r63897, r63898, r63899, r63900, r63901, r63902: assorted working ...tstarling01:21, 23 March 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57867Update HTMLForm for upcoming Special:Upload rewrite....btongminh19:29, 18 October 2009

Comments

#Comment by Catrope (talk | contribs)   08:12, 15 March 2010

Patch contributed by Bawolff (forgot to mention this in the commit message)

Status & tagging log