r63776 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63775‎ | r63776 | r63777 >
Date:17:31, 15 March 2010
Author:mah
Status:reverted (Comments)
Tags:
Comment:
off-by-one error: the fullwidth z was not being converted.
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
@@ -1716,7 +1716,7 @@
17171717 */
17181718 protected static function convertDoubleWidth( $string ) {
17191719 $string = preg_replace( '/\xef\xbc([\x80-\xbf])/e', 'chr((ord("$1") & 0x3f) + 0x20)', $string );
1720 - $string = preg_replace( '/\xef\xbd([\x80-\x99])/e', 'chr((ord("$1") & 0x3f) + 0x60)', $string );
 1720+ $string = preg_replace( '/\xef\xbd([\x80-\x9a])/e', 'chr((ord("$1") & 0x3f) + 0x60)', $string );
17211721 return $string;
17221722 }
17231723

Follow-up revisions

RevisionCommit summaryAuthorDate
r76240Test for Language::convertDoubleWidth (followup r64088 and r63776)hashar11:30, 7 November 2010

Comments

#Comment by Hashar (talk | contribs)   10:11, 7 November 2010

made ten time faster with r64088. Marking reverted

Status & tagging log