r63710 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63709‎ | r63710 | r63711 >
Date:21:09, 13 March 2010
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Fixed some doxygen warnings
Modified paths:
  • /trunk/phase3/includes/specials/SpecialProtectedpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialProtectedtitles.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialProtectedtitles.php
@@ -85,10 +85,11 @@
8686 }
8787
8888 /**
89 - * @param $namespace int
 89+ * @param $namespace Integer:
9090 * @param $type string
9191 * @param $level string
92 - * @param $minsize int
 92+ * @param $sizetype Unused
 93+ * @param $size Unused
9394 * @private
9495 */
9596 function showOptions( $namespace, $type='edit', $level, $sizetype, $size ) {
@@ -110,7 +111,7 @@
111112 * Prepare the namespace filter drop-down; standard namespace
112113 * selector, sans the MediaWiki namespace
113114 *
114 - * @param mixed $namespace Pre-select namespace
 115+ * @param $namespace Mixed: pre-select namespace
115116 * @return string
116117 */
117118 function getNamespaceMenu( $namespace = null ) {
Index: trunk/phase3/includes/specials/SpecialProtectedpages.php
@@ -123,14 +123,14 @@
124124 }
125125
126126 /**
127 - * @param $namespace int
128 - * @param $type string
129 - * @param $level string
130 - * @param $minsize int
131 - * @param $indefOnly bool
132 - * @param $cascadeOnly bool
133 - * @return string Input form
134 - * @private
 127+ * @param $namespace Integer
 128+ * @param $type String: restriction type
 129+ * @param $level String: restriction level
 130+ * @param $sizetype String: "min" or "max"
 131+ * @param $size Integer
 132+ * @param $indefOnly Boolean: only indefinie protection
 133+ * @param $cascadeOnly Boolean: only cascading protection
 134+ * @return String: input form
135135 */
136136 protected function showOptions( $namespace, $type='edit', $level, $sizetype, $size, $indefOnly, $cascadeOnly ) {
137137 global $wgScript;
@@ -157,8 +157,8 @@
158158 * Prepare the namespace filter drop-down; standard namespace
159159 * selector, sans the MediaWiki namespace
160160 *
161 - * @param mixed $namespace Pre-select namespace
162 - * @return string
 161+ * @param $namespace Mixed: pre-select namespace
 162+ * @return String
163163 */
164164 protected function getNamespaceMenu( $namespace = null ) {
165165 return "<span style='white-space: nowrap'>" .

Follow-up revisions

RevisionCommit summaryAuthorDate
r72307Address comment on r63710, rm unused paramtersdemon19:40, 3 September 2010

Comments

#Comment by Happy-melon (talk | contribs)   19:40, 14 May 2010

Why not just remove $size and $sizetype if they're unused?

Status & tagging log