r63549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63548‎ | r63549 | r63550 >
Date:12:59, 10 March 2010
Author:demon
Status:ok
Tags:
Comment:
Fix child class visibility
Modified paths:
  • /trunk/phase3/maintenance/addwiki.php (modified) (history)
  • /trunk/phase3/maintenance/checkSyntax.php (modified) (history)
  • /trunk/phase3/maintenance/commandLine.inc (modified) (history)
  • /trunk/phase3/maintenance/findhooks.php (modified) (history)
  • /trunk/phase3/maintenance/patchSql.php (modified) (history)
  • /trunk/phase3/maintenance/rebuildtextindex.php (modified) (history)
  • /trunk/phase3/maintenance/renameDbPrefix.php (modified) (history)
  • /trunk/phase3/maintenance/renamewiki.php (modified) (history)
  • /trunk/phase3/maintenance/runBatchedQuery.php (modified) (history)
  • /trunk/phase3/maintenance/sql.php (modified) (history)
  • /trunk/phase3/maintenance/sqlite.php (modified) (history)
  • /trunk/phase3/maintenance/updateSearchIndex.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/renamewiki.php
@@ -33,7 +33,7 @@
3434 $this->addArg( 'newdb', 'New DB name' );
3535 }
3636
37 - protected function getDbType() {
 37+ public function getDbType() {
3838 return Maintenance::DB_ADMIN;
3939 }
4040
Index: trunk/phase3/maintenance/runBatchedQuery.php
@@ -50,7 +50,7 @@
5151 } while ( $affected > 0 );
5252 }
5353
54 - protected function getDbType() {
 54+ public function getDbType() {
5555 return Maintenance::DB_ADMIN;
5656 }
5757 }
Index: trunk/phase3/maintenance/checkSyntax.php
@@ -39,7 +39,7 @@
4040 $this->addOption( 'syntax-only', 'Check for syntax validity only, skip code style warnings' );
4141 }
4242
43 - protected function getDbType() {
 43+ public function getDbType() {
4444 return Maintenance::DB_NONE;
4545 }
4646
Index: trunk/phase3/maintenance/updateSearchIndex.php
@@ -40,7 +40,7 @@
4141 $this->addOption( 'l', 'How long the searchindex and revision tables will be locked for', false, true );
4242 }
4343
44 - protected function getDbType() {
 44+ public function getDbType() {
4545 return Maintenance::DB_ADMIN;
4646 }
4747
Index: trunk/phase3/maintenance/commandLine.inc
@@ -18,7 +18,7 @@
1919 }
2020 }
2121
22 - protected function getDbType() {
 22+ public function getDbType() {
2323 global $wgUseNormalUser;
2424
2525 return ( isset( $wgUseNormalUser ) && $wgUseNormalUser ) ?
Index: trunk/phase3/maintenance/addwiki.php
@@ -38,7 +38,7 @@
3939 $this->addArg( 'dbname', 'Name of database to create' );
4040 }
4141
42 - protected function getDbType() {
 42+ public function getDbType() {
4343 return Maintenance::DB_ADMIN;
4444 }
4545
Index: trunk/phase3/maintenance/patchSql.php
@@ -30,7 +30,7 @@
3131 $this->addArg( 'patch-name', 'Name of the patch file, either full path or in maintenance/archives' );
3232 }
3333
34 - protected function getDbType() {
 34+ public function getDbType() {
3535 return Maintenance::DB_ADMIN;
3636 }
3737
Index: trunk/phase3/maintenance/findhooks.php
@@ -43,7 +43,7 @@
4444 $this->addOption( 'online', 'Check against mediawiki.org hook documentation' );
4545 }
4646
47 - protected function getDbType() {
 47+ public function getDbType() {
4848 return Maintenance::DB_NONE;
4949 }
5050
Index: trunk/phase3/maintenance/renameDbPrefix.php
@@ -30,7 +30,7 @@
3131 $this->addOption( "new", "New db prefix [0 for none]", true, true );
3232 }
3333
34 - protected function getDbType() {
 34+ public function getDbType() {
3535 return Maintenance::DB_ADMIN;
3636 }
3737
Index: trunk/phase3/maintenance/rebuildtextindex.php
@@ -35,7 +35,7 @@
3636 $this->mDescription = "Rebuild search index table from scratch";
3737 }
3838
39 - protected function getDbType() {
 39+ public function getDbType() {
4040 return Maintenance::DB_ADMIN;
4141 }
4242
Index: trunk/phase3/maintenance/sql.php
@@ -70,7 +70,7 @@
7171 }
7272 }
7373
74 - protected function getDbType() {
 74+ public function getDbType() {
7575 return Maintenance::DB_ADMIN;
7676 }
7777 }
Index: trunk/phase3/maintenance/sqlite.php
@@ -35,7 +35,7 @@
3636 * While we use database connection, this simple lie prevents useless --dbpass and
3737 * --dbuser options from appearing in help message for this script.
3838 */
39 - protected function getDbType() {
 39+ public function getDbType() {
4040 return Maintenance::DB_NONE;
4141 }
4242

Follow-up revisions

RevisionCommit summaryAuthorDate
r63550Backport r63549 to REL1_16demon13:38, 10 March 2010

Status & tagging log