r63548 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63547‎ | r63548 | r63549 >
Date:12:54, 10 March 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Backport r63545,r63546 REL1_16 (Fix regression from r51677, still need to load AdminSettings if it exists for back-compat)
Modified paths:
  • /branches/REL1_16/phase3 (modified) (history)
  • /branches/REL1_16/phase3/maintenance/Maintenance.php (modified) (history)
  • /branches/REL1_16/phase3/maintenance/doMaintenance.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/maintenance/doMaintenance.php
@@ -76,6 +76,11 @@
7777 } else {
7878 require_once( $maintenance->loadSettings() );
7979 }
 80+if ( $maintenance->getDbType() === Maintenance::DB_ADMIN &&
 81+ is_readable( "$IP/AdminSettings.php" ) )
 82+{
 83+ require( "$IP/AdminSettings.php" );
 84+}
8085 $maintenance->finalSetup();
8186 // Some last includes
8287 require_once( "$IP/includes/Setup.php" );
Index: branches/REL1_16/phase3/maintenance/Maintenance.php
@@ -292,7 +292,7 @@
293293 * Maintenance::DB_ADMIN - For admin DB access
294294 * @return int
295295 */
296 - protected function getDbType() {
 296+ public function getDbType() {
297297 return Maintenance::DB_STD;
298298 }
299299
Property changes on: branches/REL1_16/phase3
___________________________________________________________________
Modified: svn:mergeinfo
300300 Reverse-merged /branches/REL1_15/phase3:r51646
301301 Reverse-merged /branches/sqlite:r58211-58321
302302 Merged /trunk/phase3:r63545-63546

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r51677* AdminSettings is dead, forever and ever...demon03:39, 10 June 2009
r63545Fix regression from r51677, still need to load AdminSettings if it exists for...demon12:44, 10 March 2010
r63546Followup r63545: Whoops make that publicdemon12:45, 10 March 2010

Comments

#Comment by Tim Starling (talk | contribs)   18:34, 12 March 2010

Thanks, upgradeTest.py is working again now.

Status & tagging log