r63446 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63445‎ | r63446 | r63447 >
Date:00:20, 9 March 2010
Author:tparscal
Status:ok
Tags:
Comment:
Bump and rebuild for r63444 (oops).
Modified paths:
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -476,7 +476,7 @@
477477 text-transform: capitalize;
478478 float: left;
479479 width: 25%;
480 - line-height: 1.5em;
 480+ line-height: 2.25em;
481481 }
482482 .wikiEditor-template-dialog-fields textarea {
483483 float: right;
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -453,7 +453,7 @@
454454 text-transform:capitalize;
455455 float:left;
456456 width:25%;
457 -line-height:1.5em;
 457+line-height:2.25em;
458458 }
459459 .wikiEditor-template-dialog-fields textarea{
460460 float:right;
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -9342,7 +9342,6 @@
93439343 // param is the template name, skip it
93449344 continue;
93459345 }
9346 -
93479346 var paramText = typeof param == 'string' ?
93489347 param.name.replace( /[\_\-]/g, ' ' ) :
93499348 param.name;
@@ -9387,6 +9386,7 @@
93889387 }
93899388 // Remove any leftover rows
93909389 $rows.remove();
 9390+ $fields.find( 'label' ).autoEllipsis();
93919391 }
93929392 // Ensure our close button doesn't recieve the ui-state-focus class
93939393 $( this ).parent( '.ui-dialog' ).find( '.ui-dialog-titlebar-close' )
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js
@@ -647,7 +647,7 @@
648648 </fieldset>',init:function(){$(this).find('[rel]').each(function(){$(this).text(mw.usability.getMsg($(this).attr('rel')));});},dialog:{width:600,height:400,dialogClass:'wikiEditor-toolbar-dialog',buttons:{'wikieditor-template-editor-dialog-submit':function(){var $templateDiv=$(this).data('templateDiv');context.fn.highlightLine($templateDiv);var $templateText=$templateDiv.children('.wikiEditor-template-text');var templateModel=$templateText.data('model');$(this).find('.wikiEditor-template-dialog-field-wrapper textarea').each(function(){templateModel.setValue($(this).data('name'),$(this).val());});$.wikiEditor.modules.templateEditor.fn.updateModel($templateText,templateModel);$(this).dialog('close');}},open:function(){var $templateDiv=$(this).data('templateDiv');var $templateText=$templateDiv.children('.wikiEditor-template-text');var templateModel=$templateText.data('model');if($templateText.html()!=$templateText.data('oldHTML')){templateModel=$.wikiEditor.modules.templateEditor.fn.updateModel($templateText);}
649649 var params=templateModel.getAllInitialParams();var $fields=$(this).find('.wikiEditor-template-dialog-fields').empty();var $rows=$fields.find('.wikiEditor-template-dialog-field-wrapper');for(var paramIndex in params){var param=params[paramIndex];if(typeof param.name=='undefined'){continue;}
650650 var paramText=typeof param=='string'?param.name.replace(/[\_\-]/g,' '):param.name;var paramVal=templateModel.getValue(param.name);if($rows.length>0){var $row=$rows.eq(0);$row.children('label').text(paramText);$row.children('input').val(paramVal);$rows=$rows.not($row);}else{var $paramRow=$('<div />').addClass('wikiEditor-template-dialog-field-wrapper');$('<label />').text(paramText).appendTo($paramRow);$('<textarea />').data('name',param.name).val(paramVal).bind('cut paste keypress click',function(){$this=$(this);setTimeout(function(){var expanded=$this.data('expanded');if($this.val().length>24){if(!expanded){$this.animate({'height':'4.5em'},'fast');$this.data('expanded',true);}}else{if(expanded){$this.animate({'height':'1.5em'},'fast');$this.data('expanded',false);}}},0);}).appendTo($paramRow);$('<div style="clear:both"></div>').appendTo($paramRow);$fields.append($paramRow);}
651 -$rows.remove();}
 651+$rows.remove();$fields.find('label').autoEllipsis();}
652652 $(this).parent('.ui-dialog').find('.ui-dialog-titlebar-close').removeClass('ui-state-focus');}}};function createDialog($templateDiv){context.$textarea.wikiEditor('addDialog',{'templateEditor':dialog});$('#'+dialog.id).data('templateDiv',$templateDiv).dialog('open');}},unwrapTemplate:function($wrapper){$wrapper.parent().replaceWith($wrapper);},updateModel:function($templateText,model){var context=$templateText.data('marker').context;var text;if(typeof model=='undefined'){text=context.fn.htmlToText($templateText.html());}else{text=model.getText();}
653653 $templateText.text(text);$templateText.html($templateText.html().replace(/\n/g,'<br />'));$templateText.data('oldHTML',$templateText.html());if(typeof model=='undefined'){model=new $.wikiEditor.modules.templateEditor.fn.model(text);$templateText.data('model',model);}
654654 return model;},getTemplateInfo:function(templateName){var templateInfo='';return $(templateInfo);},model:function(wikitext){var collapsible=true;function Param(name,value,number,nameIndex,equalsIndex,valueIndex){this.name=name;this.value=value;this.number=number;this.nameIndex=nameIndex;this.equalsIndex=equalsIndex;this.valueIndex=valueIndex;}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63444Merge r63349-r63386aaron23:29, 8 March 2010

Status & tagging log