r63445 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63444‎ | r63445 | r63446 >
Date:00:19, 9 March 2010
Author:tparscal
Status:ok
Tags:
Comment:
Added auto-ellipsis to template form field names. Also adjusted some alignments.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.dialogs.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.templateEditor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -22,18 +22,18 @@
2323 array( 'src' => 'css/vector.collapsibleNav.css', 'version' => 7 ),
2424 array( 'src' => 'css/vector.footerCleanup.css', 'version' => 1 ),
2525 array( 'src' => 'css/wikiEditor.css', 'version' => 12 ),
26 - array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 24 ),
 26+ array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 25 ),
2727 array( 'src' => 'css/wikiEditor.preview.css', 'version' => 1 ),
2828 array( 'src' => 'css/wikiEditor.toc.css', 'version' => 28 ),
2929 array( 'src' => 'css/wikiEditor.toolbar.css', 'version' => 11 ),
3030 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3131 ),
3232 'combined' => array(
33 - array( 'src' => 'css/combined.css', 'version' => 72 ),
 33+ array( 'src' => 'css/combined.css', 'version' => 73 ),
3434 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3535 ),
3636 'minified' => array(
37 - array( 'src' => 'css/combined.min.css', 'version' => 72 ),
 37+ array( 'src' => 'css/combined.min.css', 'version' => 73 ),
3838 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3939 ),
4040 )
@@ -78,14 +78,14 @@
7979 array( 'src' => 'js/plugins/jquery.wikiEditor.dialogs.js', 'version' => 19 ),
8080 array( 'src' => 'js/plugins/jquery.wikiEditor.toc.js', 'version' => 97 ),
8181 array( 'src' => 'js/plugins/jquery.wikiEditor.preview.js', 'version' => 11 ),
82 - array( 'src' => 'js/plugins/jquery.wikiEditor.templateEditor.js', 'version' => 39 ),
 82+ array( 'src' => 'js/plugins/jquery.wikiEditor.templateEditor.js', 'version' => 40 ),
8383 array( 'src' => 'js/plugins/jquery.wikiEditor.publish.js', 'version' => 3 ),
8484 ),
8585 'combined' => array(
86 - array( 'src' => 'js/plugins.combined.js', 'version' => 308 ),
 86+ array( 'src' => 'js/plugins.combined.js', 'version' => 309 ),
8787 ),
8888 'minified' => array(
89 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 308 ),
 89+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 309 ),
9090 ),
9191 ),
9292 );
Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.dialogs.css
@@ -229,7 +229,7 @@
230230 text-transform: capitalize;
231231 float: left;
232232 width: 25%;
233 - line-height: 1.5em;
 233+ line-height: 2.25em;
234234 }
235235 .wikiEditor-template-dialog-fields textarea {
236236 float: right;
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.templateEditor.js
@@ -240,7 +240,6 @@
241241 // param is the template name, skip it
242242 continue;
243243 }
244 -
245244 var paramText = typeof param == 'string' ?
246245 param.name.replace( /[\_\-]/g, ' ' ) :
247246 param.name;
@@ -285,6 +284,7 @@
286285 }
287286 // Remove any leftover rows
288287 $rows.remove();
 288+ $fields.find( 'label' ).autoEllipsis();
289289 }
290290 // Ensure our close button doesn't recieve the ui-state-focus class
291291 $( this ).parent( '.ui-dialog' ).find( '.ui-dialog-titlebar-close' )

Status & tagging log