r63349 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63348‎ | r63349 | r63350 >
Date:22:51, 6 March 2010
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Removed link from right-unreviewedpages, doesn't format at Special:GlobalGroupPermissions
Modified paths:
  • /trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/language/FlaggedRevs.i18n.php
@@ -189,7 +189,7 @@
190190 'right-review' => 'Mark revisions as being "checked"',
191191 'right-stablesettings' => 'Configure how the published version is selected and displayed',
192192 'right-validate' => 'Mark revisions as being "quality"',
193 - 'right-unreviewedpages' => 'View the [[Special:UnreviewedPages|list of unreviewed pages]]',
 193+ 'right-unreviewedpages' => 'View the list of unreviewed pages', # no links allowed
194194 'rights-editor-autosum' => 'autopromoted',
195195 'rights-editor-revoke' => 'removed editor status from [[$1]]', # B/C
196196 'specialpages-group-quality' => 'Quality assurance',

Follow-up revisions

RevisionCommit summaryAuthorDate
r63354Reverted r63349; not needed due to r61599aaron01:54, 7 March 2010
r63444Merge r63349-r63386aaron23:29, 8 March 2010

Comments

#Comment by Siebrand (talk | contribs)   23:35, 6 March 2010

Why not fix Special:GlobalGroupPermissions ? AFAIK that's an extension page, while it just works on Special:ListGroupRights?

#Comment by Aaron Schulz (talk | contribs)   00:19, 7 March 2010

You can do that it you want :)

#Comment by Siebrand (talk | contribs)   10:28, 7 March 2010

The issue was more that you removed core supported functionality because an extension was not supporting the core feature.

Status & tagging log