r63388 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63387‎ | r63388 | r63389 >
Date:13:49, 8 March 2010
Author:freakolowsky
Status:reverted
Tags:
Comment:
dbprefix_varname in internalDefaults take precedence over _varname i.e. oracle_InstallUser instead of _InstallUser for oracle
Modified paths:
  • /branches/new-installer/phase3/includes/installer/InstallerDBType.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/OracleInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/OracleInstaller.php
@@ -11,10 +11,11 @@
1212 );
1313
1414 var $internalDefaults = array(
15 - '_InstallUser' => 'sys',
16 - '_InstallPassword' => '',
 15+ 'oracle_SameAccount' => false,
 16+ 'oracle_InstallUser' => 'sys'
1717 );
1818
 19+
1920 function getName() {
2021 return 'oracle';
2122 }
Index: branches/new-installer/phase3/includes/installer/InstallerDBType.php
@@ -128,7 +128,9 @@
129129 function getVar( $var, $default = null ) {
130130 $defaults = $this->getGlobalDefaults();
131131 $internal = $this->getInternalDefaults();
132 - if ( isset( $defaults[$var] ) ) {
 132+ if ( isset( $internal[$this->getName().$var] ) ) {
 133+ return $internal[$this->getName().$var];
 134+ } elseif ( isset( $defaults[$var] ) ) {
133135 $default = $defaults[$var];
134136 } elseif ( isset( $internal[$var] ) ) {
135137 $default = $internal[$var];

Follow-up revisions

RevisionCommit summaryAuthorDate
r63390Revert r63388 (dbprefix_varname in internalDefaults take precedence over _var...demon14:16, 8 March 2010

Status & tagging log