r63390 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r63389‎ | r63390 | r63391 >
Date:14:16, 8 March 2010
Author:demon
Status:ok
Tags:
Comment:
Revert r63388 (dbprefix_varname in internalDefaults take precedence over _varname i.e. oracle_InstallUser instead of _InstallUser for oracle). Understand the need to override $internalDefaults, need different implementation though.
Modified paths:
  • /branches/new-installer/phase3/includes/installer/InstallerDBType.php (modified) (history)
  • /branches/new-installer/phase3/includes/installer/OracleInstaller.php (modified) (history)

Diff [purge]

Index: branches/new-installer/phase3/includes/installer/OracleInstaller.php
@@ -11,11 +11,10 @@
1212 );
1313
1414 var $internalDefaults = array(
15 - 'oracle_SameAccount' => false,
16 - 'oracle_InstallUser' => 'sys'
 15+ '_InstallUser' => 'sys',
 16+ '_InstallPassword' => '',
1717 );
1818
19 -
2019 function getName() {
2120 return 'oracle';
2221 }
Index: branches/new-installer/phase3/includes/installer/InstallerDBType.php
@@ -128,9 +128,7 @@
129129 function getVar( $var, $default = null ) {
130130 $defaults = $this->getGlobalDefaults();
131131 $internal = $this->getInternalDefaults();
132 - if ( isset( $internal[$this->getName().$var] ) ) {
133 - return $internal[$this->getName().$var];
134 - } elseif ( isset( $defaults[$var] ) ) {
 132+ if ( isset( $defaults[$var] ) ) {
135133 $default = $defaults[$var];
136134 } elseif ( isset( $internal[$var] ) ) {
137135 $default = $internal[$var];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63388dbprefix_varname in internalDefaults take precedence over _varname i.e. oracl...freakolowsky13:49, 8 March 2010

Status & tagging log