r62969 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62968‎ | r62969 | r62970 >
Date:19:03, 25 February 2010
Author:raymond
Status:ok
Tags:
Comment:
Follow-up r62957: Make function public. Fixes "Warning: call_user_func_array() expects parameter 1 to be a valid callback, cannot access private method DynamicSidebar::modifySidebar()"
Modified paths:
  • /trunk/extensions/DynamicSidebar/DynamicSidebar.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DynamicSidebar/DynamicSidebar.body.php
@@ -16,13 +16,13 @@
1717 }
1818
1919 /**
20 - * Called from SkinBeforeParseSidebar hook. Modifies the sidebar
 20+ * Called from SkinBuildSidebar hook. Modifies the sidebar
2121 * via callbacks.
2222 *
2323 * @param Skin $skin
2424 * @param string $sidebar
2525 */
26 - private static function modifySidebar( $skin, &$sidebar ) {
 26+ public static function modifySidebar( $skin, &$sidebar ) {
2727 global $wgDynamicSidebarUseGroups, $wgDynamicSidebarUseUserpages;
2828 global $wgDynamicSidebarUseCategories;
2929

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62957DynamicSidebar: Some cleanup...catrope15:29, 25 February 2010

Status & tagging log