r62817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62816‎ | r62817 | r62818 >
Date:10:48, 22 February 2010
Author:tstarling
Status:ok
Tags:
Comment:
Fix r62774 in a different way.
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -114,7 +114,7 @@
115115 }
116116
117117 static function profilePreferences( $user, &$defaultPreferences ) {
118 - global $wgLang;
 118+ global $wgLang, $wgUser;
119119 ## User info #####################################
120120 // Information panel
121121 $defaultPreferences['username'] =
@@ -209,7 +209,6 @@
210210 );
211211
212212 if( $wgAuth->allowPasswordChange() ) {
213 - global $wgUser; // For skin.
214213 $link = $wgUser->getSkin()->link( SpecialPage::getTitleFor( 'Resetpass' ),
215214 wfMsgHtml( 'prefs-resetpass' ), array(),
216215 array( 'returnto' => SpecialPage::getTitleFor( 'Preferences' ) ) );
@@ -362,7 +361,6 @@
363362 $disableEmailPrefs = false;
364363 } else {
365364 $disableEmailPrefs = true;
366 - global $wgUser; // wgUser is okay here, it's for display
367365 $skin = $wgUser->getSkin();
368366 $emailauthenticated = wfMsgExt( 'emailnotauthenticated', 'parseinline' ) . '<br />' .
369367 $skin->link(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62774remove duplicate global definitionsmidom17:03, 21 February 2010

Status & tagging log