r62774 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62773‎ | r62774 | r62775 >
Date:17:03, 21 February 2010
Author:midom
Status:resolved
Tags:
Comment:
remove duplicate global definitions
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -209,7 +209,6 @@
210210 );
211211
212212 if( $wgAuth->allowPasswordChange() ) {
213 - global $wgUser; // For skin.
214213 $link = $wgUser->getSkin()->link( SpecialPage::getTitleFor( 'Resetpass' ),
215214 wfMsgHtml( 'prefs-resetpass' ), array(),
216215 array( 'returnto' => SpecialPage::getTitleFor( 'Preferences' ) ) );
@@ -781,7 +780,6 @@
782781 'section' => 'rc/advancedrc',
783782 );
784783
785 - global $wgUseRCPatrol;
786784 if( $wgUseRCPatrol ) {
787785 $defaultPreferences['hidepatrolled'] =
788786 array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r62782Partially revert r62774 to prevent PHP Notice: Undefined variable: wgUser in...siebrand17:28, 21 February 2010
r62817Fix r62774 in a different way.tstarling10:48, 22 February 2010

Status & tagging log