| Index: trunk/extensions/CodeReview/backend/Subversion.php |
| — | — | @@ -109,13 +109,14 @@ |
| 110 | 110 | $this->getExtraArgs(), |
| 111 | 111 | wfEscapeShellArg( $this->mRepo ) ); |
| 112 | 112 | |
| 113 | | - $Result = wfShellExec( $command ); |
| 114 | | - if ( $Result == "" ) |
| | 113 | + $result = wfShellExec( $command ); |
| | 114 | + if ( $result == "" ) { |
| 115 | 115 | return false; |
| 116 | | - elseif ( strpos( $Result, "No repository found" ) !== false ) |
| | 116 | + } elseif ( strpos( $result, "No repository found" ) !== false ) { |
| 117 | 117 | return false; |
| 118 | | - else |
| | 118 | + } else { |
| 119 | 119 | return true; |
| | 120 | + } |
| 120 | 121 | } |
| 121 | 122 | |
| 122 | 123 | function getFile( $path, $rev = null ) { |
| Index: trunk/extensions/CodeReview/svnImport.php |
| — | — | @@ -64,8 +64,9 @@ |
| 65 | 65 | |
| 66 | 66 | echo "Syncing repo $repoName from r$start to HEAD...\n"; |
| 67 | 67 | |
| 68 | | - if ( !$svn->canConnect() ) |
| | 68 | + if ( !$svn->canConnect() ) { |
| 69 | 69 | die( "Unable to connect to repository.\n" ); |
| | 70 | + } |
| 70 | 71 | |
| 71 | 72 | while ( true ) { |
| 72 | 73 | $log = $svn->getLog( '', $start, $start + $chunkSize - 1 ); |