r62756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r62755‎ | r62756 | r62757 >
Date:01:43, 21 February 2010
Author:simetrical
Status:reverted (Comments)
Tags:
Comment:
Revert "Kill off IE50Fixes. Adds extra clutter to the head, and market share is down below 0.03% (http://is.gd/6jyWo).&quot;

This reverts commit d7b597d6720762330b11538b4b19554bfb6d11a1.
Modified paths:
  • /trunk/phase3/skins/Chick.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/chick/IE50Fixes.css (added) (history)
  • /trunk/phase3/skins/chick/IE55Fixes.css (added) (history)
  • /trunk/phase3/skins/monobook/IE50Fixes.css (added) (history)
  • /trunk/phase3/skins/monobook/IE55Fixes.css (added) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/IE50Fixes.css
——@@ -0,0 +1,67 @@
 2+/*
 3+** IE5.0 Fix Stylesheet
 4+*/
 5+
 6+#column-content {
 7+ margin: 0 !important;
 8+ float: none;
 9+}
 10+#column-content #content {
 11+ margin-top: 3em;
 12+ height: 1%;
 13+}
 14+#column-one {
 15+ position: absolute;
 16+ overflow: visible;
 17+ top: 0;
 18+ left: 0;
 19+ z-index: 3;
 20+}
 21+#footer {
 22+ margin: 0 0 0 13.6em;
 23+}
 24+
 25+/* IE 5 & 5.5 interpret keyword sizes one off */
 26+body { font-size: xx-small; }
 27+/*
 28+** the edit tabs
 29+*/
 30+#p-cactions li {
 31+ float: left;
 32+ padding-top: 0;
 33+ padding-bottom: 0 !important;
 34+ height: 0.9em;
 35+}
 36+#p-cactions li a {
 37+ display: block;
 38+ padding-bottom: 0.045em;
 39+}
 40+#p-cactions li.selected a {
 41+ padding-bottom: 0.17em;
 42+}
 43+#p-cactions li a:hover {
 44+ padding-bottom: 0.17em;
 45+}
 46+/* 5.0 doesn't like the background icon for external links and user */
 47+.link-external,
 48+.external {
 49+ background: none;
 50+ padding: 0;
 51+}
 52+#p-personal ul { float: right }
 53+#p-personal li { float: left }
 54+li#pt-userpage,
 55+li#pt-anonuserpage,
 56+li#pt-login,
 57+li#pt-logout {
 58+ background: none;
 59+ padding-left: none;
 60+}
 61+.visualClear {
 62+ width:100%;
 63+ height: 0px;
 64+ padding:0;
 65+ margin:0;
 66+}
 67+#firstHeading { margin-bottom: 0.3em; }
 68+/*div{ border:1px solid Red !important;}*/
Property changes on: trunk/phase3/skins/chick/IE50Fixes.css
___________________________________________________________________
Name: svn:eol-style
169 + native
Index: trunk/phase3/skins/chick/IE55Fixes.css
——@@ -0,0 +1,81 @@
 2+/* IE5.5/win- only fixes */
 3+
 4+#column-content {
 5+ float: none;
 6+ margin-left: 0;
 7+ height: 1%;
 8+}
 9+#column-content #content {
 10+ position: relative;
 11+ z-index: 5;
 12+ margin-left: 12.2em;
 13+ margin-top: 3em;
 14+ height: 1%;
 15+}
 16+#column-one {
 17+ position: absolute;
 18+ top: 0;
 19+ left: 0;
 20+ z-index: 4;
 21+ width: 100%;
 22+}
 23+#footer {
 24+ margin-left: 13.6em;
 25+ border-left: 1px solid #fabd23;
 26+}
 27+
 28+/*#bodyContent div,
 29+#bodyContent pre { overflow: auto; }*/
 30+
 31+#p-personal { padding-bottom: 0.1em; }
 32+
 33+body { font-size: xx-small; }
 34+
 35+#p-cactions {
 36+ width: 76% !important;
 37+ z-index: 3 !important;
 38+ float: none;
 39+}
 40+#p-cactions li {
 41+ padding-bottom: 0 !important;
 42+ border: none;
 43+ background-color: transparent;
 44+ cursor: default;
 45+ float: none !important;
 46+}
 47+#p-cactions li a {
 48+ display: inline-block !important;
 49+ vertical-align: top;
 50+ padding-bottom: 0;
 51+ border: solid #aaa;
 52+ border-width: 1px 1px 0;
 53+}
 54+#p-cactions li.selected a {
 55+ border-color: #fabd23;
 56+ padding-bottom: 0.17em;
 57+}
 58+#p-cactions li a:hover {
 59+ padding-bottom: 0.17em;
 60+}
 61+.portlet {
 62+ overflow:hidden;
 63+}
 64+#bodyContent a.external {
 65+ background: url(external.png) center right no-repeat;
 66+ padding-right: 13px;
 67+}
 68+/* show the hand */
 69+#p-logo a,
 70+#p-logo a:hover {
 71+ cursor: pointer;
 72+}
 73+.visualClear {
 74+ width:90%;
 75+ height: 1px;
 76+ padding:0;
 77+ margin:0;
 78+}
 79+
 80+#editform {
 81+ width: 100%;
 82+}
Property changes on: trunk/phase3/skins/chick/IE55Fixes.css
___________________________________________________________________
Name: svn:eol-style
183 + native
Index: trunk/phase3/skins/monobook/IE50Fixes.css
——@@ -0,0 +1,67 @@
 2+/*
 3+** IE5.0 Fix Stylesheet
 4+*/
 5+
 6+#column-content {
 7+ margin: 0 !important;
 8+ float: none;
 9+}
 10+#column-content #content {
 11+ margin-top: 3em;
 12+ height: 1%;
 13+}
 14+#column-one {
 15+ position: absolute;
 16+ overflow: visible;
 17+ top: 0;
 18+ left: 0;
 19+ z-index: 3;
 20+}
 21+#footer {
 22+ margin: 0 0 0 13.6em;
 23+}
 24+
 25+/* IE 5 & 5.5 interpret keyword sizes one off */
 26+body { font-size: xx-small; }
 27+/*
 28+** the edit tabs
 29+*/
 30+#p-cactions li {
 31+ float: left;
 32+ padding-top: 0;
 33+ padding-bottom: 0 !important;
 34+ height: 0.9em;
 35+}
 36+#p-cactions li a {
 37+ display: block;
 38+ padding-bottom: 0.045em;
 39+}
 40+#p-cactions li.selected a {
 41+ padding-bottom: 0.17em;
 42+}
 43+#p-cactions li a:hover {
 44+ padding-bottom: 0.17em;
 45+}
 46+/* 5.0 doesn't like the background icon for external links and user */
 47+.link-external,
 48+.external {
 49+ background: none;
 50+ padding: 0;
 51+}
 52+#p-personal ul { float: right }
 53+#p-personal li { float: left }
 54+li#pt-userpage,
 55+li#pt-anonuserpage,
 56+li#pt-login,
 57+li#pt-logout {
 58+ background: none;
 59+ padding-left: none;
 60+}
 61+.visualClear {
 62+ width: 100%;
 63+ height: 0px;
 64+ padding:0;
 65+ margin: 0;
 66+}
 67+#firstHeading { margin-bottom: .3em; }
 68+/*div{ border:1px solid Red !important;}*/
Property changes on: trunk/phase3/skins/monobook/IE50Fixes.css
___________________________________________________________________
Name: svn:eol-style
169 + native
Index: trunk/phase3/skins/monobook/IE55Fixes.css
——@@ -0,0 +1,85 @@
 2+/* IE5.5/win- only fixes */
 3+
 4+#column-content {
 5+ float: none;
 6+ margin-left: 0;
 7+ height: 1%;
 8+}
 9+#column-content #content {
 10+ position: relative;
 11+ z-index: 5;
 12+ margin-left: 12.2em;
 13+ margin-top: 3em;
 14+ height: 1%;
 15+}
 16+#column-one {
 17+ position: absolute;
 18+ top: 0;
 19+ left: 0;
 20+ z-index: 4;
 21+ width: 100%;
 22+}
 23+#footer {
 24+ margin-left: 13.6em;
 25+ border-left: 1px solid #fabd23;
 26+}
 27+
 28+/*#bodyContent div,
 29+#bodyContent pre { overflow: auto; }*/
 30+
 31+#p-personal { padding-bottom: .1em; }
 32+
 33+body { font-size: xx-small; }
 34+
 35+#p-cactions {
 36+ width: 76% !important;
 37+ z-index: 3 !important;
 38+ float: none;
 39+}
 40+#p-cactions li {
 41+ padding-bottom: 0 !important;
 42+ border: none;
 43+ background-color: transparent;
 44+ cursor: default;
 45+ float: none !important;
 46+}
 47+#p-cactions li a {
 48+ display: inline-block !important;
 49+ vertical-align: top;
 50+ padding-bottom: 0;
 51+ border: solid #aaa;
 52+ border-width: 1px 1px 0;
 53+}
 54+#p-cactions li.selected a {
 55+ border-color: #fabd23;
 56+ padding-bottom: 0.17em;
 57+}
 58+#p-cactions li a:hover {
 59+ padding-bottom: 0.17em;
 60+}
 61+#p-navigation a {
 62+ display: inline-block;
 63+ width: 100%;
 64+}
 65+.portlet {
 66+ overflow: hidden;
 67+}
 68+#bodyContent a.external {
 69+ background: url(external.png) center right no-repeat;
 70+ padding-right: 13px;
 71+}
 72+/* show the hand */
 73+#p-logo a,
 74+#p-logo a:hover {
 75+ cursor: pointer;
 76+}
 77+.visualClear {
 78+ width: 90%;
 79+ height: 1px;
 80+ padding: 0;
 81+ margin: 0;
 82+}
 83+
 84+#editform {
 85+ width: 100%;
 86+}
Property changes on: trunk/phase3/skins/monobook/IE55Fixes.css
___________________________________________________________________
Name: svn:eol-style
187 + native
Index: trunk/phase3/skins/Chick.php
——@@ -25,6 +25,8 @@
2626 parent::setupSkinUserCss( $out );
2727 // Append to the default screen common & print styles...
2828 $out->addStyle( 'chick/main.css', 'screen,handheld' );
 29+ $out->addStyle( 'chick/IE50Fixes.css', 'screen,handheld', 'lt IE 5.5000' );
 30+ $out->addStyle( 'chick/IE55Fixes.css', 'screen,handheld', 'IE 5.5000' );
2931 $out->addStyle( 'chick/IE60Fixes.css', 'screen,handheld', 'IE 6' );
3032 }
3133 }
Index: trunk/phase3/skins/MonoBook.php
——@@ -35,9 +35,13 @@
3636 $out->addStyle( $wgHandheldStyle, 'handheld' );
3737 }
3838
 39+ $out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
 40+ $out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );
3941 $out->addStyle( 'monobook/IE60Fixes.css', 'screen', 'IE 6' );
4042 $out->addStyle( 'monobook/IE70Fixes.css', 'screen', 'IE 7' );
 43+
4144 $out->addStyle( 'monobook/rtl.css', 'screen', '', 'rtl' );
 45+
4246 }
4347 }
4448

Comments

#Comment by Simetrical (talk | contribs)   01:46, 21 February 2010

Reverted in r62759, committed by mistake.

Status & tagging log