r62755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62754‎ | r62755 | r62756 >
Date:01:33, 21 February 2010
Author:demon
Status:ok
Tags:
Comment:
Drop a bunch of unused $wgUsers, add one missing declaration
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeCommentsListView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeReleaseNotes.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeCommentsListView.php
@@ -60,7 +60,7 @@
6161 }
6262
6363 function formatValue( $name, $value ) {
64 - global $wgUser, $wgLang;
 64+ global $wgLang;
6565 switch( $name ) {
6666 case 'cc_rev_id':
6767 return $this->mView->mSkin->link(
Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
@@ -281,7 +281,7 @@
282282 function formatValue( $name, $value ) { } // unused
283283
284284 function formatRevValue( $name, $value, $row ) {
285 - global $wgUser, $wgLang;
 285+ global $wgLang;
286286 $pathQuery = ( strlen($this->mView->mPath) ) ? array('path' => $this->mView->mPath) : array();
287287
288288 switch( $name ) {
Index: trunk/extensions/CodeReview/ui/CodeReleaseNotes.php
@@ -39,7 +39,7 @@
4040 }
4141
4242 protected function showForm() {
43 - global $wgOut, $wgScript, $wgUser;
 43+ global $wgOut, $wgScript;
4444 $special = SpecialPage::getTitleFor( 'Code', $this->mRepo->getName() . '/releasenotes' );
4545 $wgOut->addHTML(
4646 Xml::openElement( 'form', array( 'action' => $wgScript, 'method' => 'get' ) ) .
Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
@@ -30,7 +30,7 @@
3131 }
3232
3333 function execute() {
34 - global $wgOut, $wgUser, $wgLang;
 34+ global $wgOut, $wgLang;
3535 if ( !$this->mRepo ) {
3636 $view = new CodeRepoListView();
3737 $view->execute();
@@ -291,7 +291,6 @@
292292
293293 /** Parameters are the tags to be added/removed sent with the request */
294294 static function addTagForm( $addTags, $removeTags ) {
295 - global $wgUser;
296295 return '<div><table><tr><td>' .
297296 Xml::inputLabel( wfMsg( 'code-rev-tag-add' ), 'wpTag', 'wpTag', 20,
298297 self::listTags( $addTags ) ) . '</td><td>&nbsp;</td><td>' .
@@ -300,7 +299,6 @@
301300 }
302301
303302 protected function formatTag( $tag ) {
304 - global $wgUser;
305303 $repo = $this->mRepo->getName();
306304 $special = SpecialPage::getTitleFor( 'Code', "$repo/tag/$tag" );
307305 return $this->mSkin->link( $special, htmlspecialchars( $tag ) );
@@ -611,7 +609,6 @@
612610 }
613611
614612 protected function commentReplyLink( $id ) {
615 - global $wgUser;
616613 if ( !$this->canPostComments() ) return '';
617614 $repo = $this->mRepo->getName();
618615 $rev = $this->mRev->getId();

Status & tagging log