r62537 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62536‎ | r62537 | r62538 >
Date:20:08, 15 February 2010
Author:siebrand
Status:ok
Tags:
Comment:
Revert r62421. Removing "set_time_limit( 0 );" causes all kinds of time out issues running command line scripts in both maintenance/ and with cli scripts in extensions.
Modified paths:
  • /trunk/phase3/maintenance/Maintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Maintenance.php
@@ -638,6 +638,7 @@
639639 }
640640
641641 $wgShowSQLErrors = true;
 642+ @set_time_limit( 0 );
642643 ini_set( 'memory_limit', $this->memoryLimit() );
643644
644645 $wgProfiling = false; // only for Profiler.php mode; avoids OOM errors

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62421Don't need to set time limit here, already did in setup(), memory_limit still...demon03:27, 13 February 2010

Status & tagging log