r62421 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62420‎ | r62421 | r62422 >
Date:03:27, 13 February 2010
Author:demon
Status:reverted
Tags:
Comment:
Don't need to set time limit here, already did in setup(), memory_limit still needs calling this late, user might have overriden this in LocalSettings
Modified paths:
  • /trunk/phase3/maintenance/Maintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/Maintenance.php
@@ -638,7 +638,6 @@
639639 }
640640
641641 $wgShowSQLErrors = true;
642 - @set_time_limit( 0 );
643642 ini_set( 'memory_limit', $this->memoryLimit() );
644643
645644 $wgProfiling = false; // only for Profiler.php mode; avoids OOM errors

Follow-up revisions

RevisionCommit summaryAuthorDate
r62537Revert r62421. Removing "set_time_limit( 0 );" causes all kinds of time out i...siebrand20:08, 15 February 2010

Status & tagging log