r62536 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r62535
|
r62536
|
r62537
>
Date:
18:49, 15 February 2010
Author:
aaron
Status:
ok
Tags:
Comment:
Follow-up
r61741
: made load() more resistant to infinite loops if bad code uses it
Modified paths:
/trunk/extensions/FlaggedRevs/FlaggedArticleView.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
—
—
@@ -29,11 +29,11 @@
30
30
*/
31
31
protected function load() {
32
32
if ( !$this->loaded ) {
33
+ $this->loaded = true;
33
34
$this->article = self::globalArticleInstance();
34
35
if ( $this->article == null ) {
35
36
throw new MWException( 'FlaggedArticleViewer has no context article!' );
36
37
}
37
- $this->loaded = true;
38
38
}
39
39
}
40
40
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r61741
Clean up silly bug in load()
aaron
10:04, 31 January 2010
Status & tagging log
13:39, 17 February 2010
😂
(
talk
|
contribs
)
changed the
status
of r62536
[
removed:
new
added:
ok]