r62224 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62223‎ | r62224 | r62225 >
Date:08:41, 10 February 2010
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up r62220. Please fix your auto props.

http://www.mediawiki.org/wiki/Subversion/auto-props
Modified paths:
  • /trunk/extensions/Storyboard/README (modified) (history)
  • /trunk/extensions/Storyboard/StoryReview_body.php (modified) (history)
  • /trunk/extensions/Storyboard/Storyboard.alias.php (modified) (history)
  • /trunk/extensions/Storyboard/Storyboard.i18n.php (modified) (history)
  • /trunk/extensions/Storyboard/Storyboard.php (modified) (history)
  • /trunk/extensions/Storyboard/Storyboard_Settings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/StoryReview_body.php
@@ -1,28 +1,28 @@
2 -<?php
3 -
4 -/**
5 - * File holding the SpecialStoryReview class that allows reviewers to moderate the submitted stories.
6 - *
7 - * @file StoryReview_body.php
8 - * @ingroup Storyboard
9 - *
10 - * @author Jeroen De Dauw
11 - */
12 -
13 -if( !defined( 'MEDIAWIKI' ) ) {
14 - die( 'Not an entry point.' );
15 -}
16 -
17 -class SpecialStoryReview extends IncludableSpecialPage {
18 -
19 - function __construct() {
20 - parent::__construct( 'StoryReview' );
21 -
22 - wfLoadExtensionMessages( 'Storyboard' );
23 - }
24 -
25 - function execute( $language ) {
26 - global $wgOut;
27 - }
28 -
 2+<?php
 3+
 4+/**
 5+ * File holding the SpecialStoryReview class that allows reviewers to moderate the submitted stories.
 6+ *
 7+ * @file StoryReview_body.php
 8+ * @ingroup Storyboard
 9+ *
 10+ * @author Jeroen De Dauw
 11+ */
 12+
 13+if( !defined( 'MEDIAWIKI' ) ) {
 14+ die( 'Not an entry point.' );
 15+}
 16+
 17+class SpecialStoryReview extends IncludableSpecialPage {
 18+
 19+ function __construct() {
 20+ parent::__construct( 'StoryReview' );
 21+
 22+ wfLoadExtensionMessages( 'Storyboard' );
 23+ }
 24+
 25+ function execute( $language ) {
 26+ global $wgOut;
 27+ }
 28+
2929 }
\ No newline at end of file
Property changes on: trunk/extensions/Storyboard/StoryReview_body.php
___________________________________________________________________
Name: svn:eol-style
3030 + native
Index: trunk/extensions/Storyboard/Storyboard.alias.php
@@ -1,19 +1,19 @@
2 -<?php
3 -
4 -/**
5 - * Aliases for the special pages of the Storyboard extension.
6 - *
7 - * @file Storyboard.alias.php
8 - * @ingroup Storyboard
9 - *
10 - * @author Jeroen De Dauw
11 - */
12 -
13 -$aliases = array();
14 -
15 -/** English
16 - * @author Jeroen De Dauw
17 - */
18 -$aliases['en'] = array(
19 - 'StoryReview' => array( 'StoryReview' ),
 2+<?php
 3+
 4+/**
 5+ * Aliases for the special pages of the Storyboard extension.
 6+ *
 7+ * @file Storyboard.alias.php
 8+ * @ingroup Storyboard
 9+ *
 10+ * @author Jeroen De Dauw
 11+ */
 12+
 13+$aliases = array();
 14+
 15+/** English
 16+ * @author Jeroen De Dauw
 17+ */
 18+$aliases['en'] = array(
 19+ 'StoryReview' => array( 'StoryReview' ),
2020 );
\ No newline at end of file
Property changes on: trunk/extensions/Storyboard/Storyboard.alias.php
___________________________________________________________________
Name: svn:eol-style
2121 + native
Index: trunk/extensions/Storyboard/Storyboard.i18n.php
@@ -1,21 +1,21 @@
2 -<?php
3 -
4 -/**
5 - * Internationalization file for the Storyboard extension.
6 - *
7 - * @file Storyboard.i18n.php
8 - * @ingroup Storyboard
9 - *
10 - * @author Jeroen De Dauw
11 - */
12 -
13 -$messages = array();
14 -
15 -/** English
16 - * @author Jeroen De Dauw
17 - */
18 -$messages['en'] = array(
19 - // General
20 - 'storyboard_name' => 'Storyboard',
21 - 'storyboard_desc' => 'Provides a landing page for donors, a page where stories can be submitted, and a story moderation interface.',
 2+<?php
 3+
 4+/**
 5+ * Internationalization file for the Storyboard extension.
 6+ *
 7+ * @file Storyboard.i18n.php
 8+ * @ingroup Storyboard
 9+ *
 10+ * @author Jeroen De Dauw
 11+ */
 12+
 13+$messages = array();
 14+
 15+/** English
 16+ * @author Jeroen De Dauw
 17+ */
 18+$messages['en'] = array(
 19+ // General
 20+ 'storyboard_name' => 'Storyboard',
 21+ 'storyboard_desc' => 'Provides a landing page for donors, a page where stories can be submitted, and a story moderation interface.',
2222 );
\ No newline at end of file
Property changes on: trunk/extensions/Storyboard/Storyboard.i18n.php
___________________________________________________________________
Name: svn:eol-style
2323 + native
Property changes on: trunk/extensions/Storyboard/README
___________________________________________________________________
Name: svn:eol-style
2424 + native
Index: trunk/extensions/Storyboard/Storyboard.php
@@ -1,64 +1,64 @@
2 -<?php
3 -
4 -/**
5 - * Initialization file for the Storyboard extension.
6 - * Extension documentation: http://www.mediawiki.org/wiki/Extension:Storyboard
7 - *
8 - * @file Storyboard.php
9 - * @ingroup Storyboard
10 - *
11 - * @author Jeroen De Dauw
12 - */
13 -
14 -/**
15 - * This documenation group collects source code files belonging to Storyboard.
16 - *
17 - * Please do not use this group name for other code.
18 - *
19 - * @defgroup Storyboard Storyboard
20 - */
21 -
22 -if( !defined( 'MEDIAWIKI' ) ) {
23 - die( 'Not an entry point.' );
24 -}
25 -
26 -define('Storyboard_VERSION', '0');
27 -
28 -$egStoryboardScriptPath = $wgScriptPath . '/extensions/Storyboard';
29 -$egStoryboardDir = dirname( __FILE__ ) . '/';
30 -
31 -// Include the settings file.
32 -require_once($egStoryboardDir . 'Storyboard_Settings.php');
33 -
34 -// Register the initialization function of Storyboard.
35 -$wgExtensionFunctions[] = 'efStoryboardSetup';
36 -
37 -// Register the initernationalization and aliasing files of Storyboard.
38 -$wgExtensionMessagesFiles['Storyboard'] = $egStoryboardDir . 'Storyboard.i18n.php';
39 -$wgExtensionAliasesFiles['Storyboard'] = $egStoryboardDir . 'Storyboard.alias.php';
40 -
41 -// Load and register the StoryReview special page and register it's group.
42 -$wgAutoloadClasses['SpecialStoryReview'] = $egStoryboardDir . 'StoryReview_body.php';
43 -$wgSpecialPages['StoryReview'] = 'SpecialStoryReview';
44 -$wgSpecialPageGroups['StoryReview'] = 'contribution';
45 -
46 -/**
47 - * Initialization function for the Storyboard extension.
48 - */
49 -function efStoryboardSetup() {
50 - global $wgExtensionCredits;
51 -
52 - wfLoadExtensionMessages( 'Storyboard' );
53 -
54 - $wgExtensionCredits['parserhook'][] = array(
55 - 'path' => __FILE__,
56 - 'name' => wfMsg('storyboard_name'),
57 - 'version' => Storyboard_VERSION,
58 - 'author' => array('[http://bn2vs.com Jeroen De Dauw]'),
59 - 'url' => 'http://www.mediawiki.org/wiki/Extension:Storyboard',
60 - 'description' => wfMsg( 'storyboard_desc' ),
61 - 'descriptionmsg' => wfMsg( 'storyboard_desc' ),
62 - );
63 -}
64 -
65 -
 2+<?php
 3+
 4+/**
 5+ * Initialization file for the Storyboard extension.
 6+ * Extension documentation: http://www.mediawiki.org/wiki/Extension:Storyboard
 7+ *
 8+ * @file Storyboard.php
 9+ * @ingroup Storyboard
 10+ *
 11+ * @author Jeroen De Dauw
 12+ */
 13+
 14+/**
 15+ * This documenation group collects source code files belonging to Storyboard.
 16+ *
 17+ * Please do not use this group name for other code.
 18+ *
 19+ * @defgroup Storyboard Storyboard
 20+ */
 21+
 22+if( !defined( 'MEDIAWIKI' ) ) {
 23+ die( 'Not an entry point.' );
 24+}
 25+
 26+define('Storyboard_VERSION', '0');
 27+
 28+$egStoryboardScriptPath = $wgScriptPath . '/extensions/Storyboard';
 29+$egStoryboardDir = dirname( __FILE__ ) . '/';
 30+
 31+// Include the settings file.
 32+require_once($egStoryboardDir . 'Storyboard_Settings.php');
 33+
 34+// Register the initialization function of Storyboard.
 35+$wgExtensionFunctions[] = 'efStoryboardSetup';
 36+
 37+// Register the initernationalization and aliasing files of Storyboard.
 38+$wgExtensionMessagesFiles['Storyboard'] = $egStoryboardDir . 'Storyboard.i18n.php';
 39+$wgExtensionAliasesFiles['Storyboard'] = $egStoryboardDir . 'Storyboard.alias.php';
 40+
 41+// Load and register the StoryReview special page and register it's group.
 42+$wgAutoloadClasses['SpecialStoryReview'] = $egStoryboardDir . 'StoryReview_body.php';
 43+$wgSpecialPages['StoryReview'] = 'SpecialStoryReview';
 44+$wgSpecialPageGroups['StoryReview'] = 'contribution';
 45+
 46+/**
 47+ * Initialization function for the Storyboard extension.
 48+ */
 49+function efStoryboardSetup() {
 50+ global $wgExtensionCredits;
 51+
 52+ wfLoadExtensionMessages( 'Storyboard' );
 53+
 54+ $wgExtensionCredits['parserhook'][] = array(
 55+ 'path' => __FILE__,
 56+ 'name' => wfMsg('storyboard_name'),
 57+ 'version' => Storyboard_VERSION,
 58+ 'author' => array('[http://bn2vs.com Jeroen De Dauw]'),
 59+ 'url' => 'http://www.mediawiki.org/wiki/Extension:Storyboard',
 60+ 'description' => wfMsg( 'storyboard_desc' ),
 61+ 'descriptionmsg' => wfMsg( 'storyboard_desc' ),
 62+ );
 63+}
 64+
 65+
Property changes on: trunk/extensions/Storyboard/Storyboard.php
___________________________________________________________________
Name: svn:eol-style
6666 + native
Index: trunk/extensions/Storyboard/Storyboard_Settings.php
@@ -1,19 +1,19 @@
2 -<?php
3 -
4 -/**
5 - * File defining the settings for the Storyboard extension.
6 - * More info can be found at http://www.mediawiki.org/wiki/Extension:Storyboard
7 - *
8 - * NOTICE:
9 - * Changing one of these settings can be done by copieng or cutting it,
10 - * and placing it in LocalSettings.php, AFTER the inclusion of Storyboard.
11 - *
12 - * @file Storyboard_Settings.php
13 - * @ingroup Storyboard
14 - *
15 - * @author Jeroen De Dauw
16 - */
17 -
18 -if( !defined( 'MEDIAWIKI' ) ) {
19 - die( 'Not an entry point.' );
 2+<?php
 3+
 4+/**
 5+ * File defining the settings for the Storyboard extension.
 6+ * More info can be found at http://www.mediawiki.org/wiki/Extension:Storyboard
 7+ *
 8+ * NOTICE:
 9+ * Changing one of these settings can be done by copieng or cutting it,
 10+ * and placing it in LocalSettings.php, AFTER the inclusion of Storyboard.
 11+ *
 12+ * @file Storyboard_Settings.php
 13+ * @ingroup Storyboard
 14+ *
 15+ * @author Jeroen De Dauw
 16+ */
 17+
 18+if( !defined( 'MEDIAWIKI' ) ) {
 19+ die( 'Not an entry point.' );
2020 }
\ No newline at end of file
Property changes on: trunk/extensions/Storyboard/Storyboard_Settings.php
___________________________________________________________________
Name: svn:eol-style
2121 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r62325Storyboard: svn:eol-style native. Please fix your autoprops, see also r62224catrope21:16, 11 February 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62220Storyboard extensionjeroendedauw03:15, 10 February 2010

Status & tagging log