r62225 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r62224‎ | r62225 | r62226 >
Date:08:47, 10 February 2010
Author:siebrand
Status:ok
Tags:
Comment:
Follow-up r62220:
* rename messages (underscore to dash)
* remove trailing whitespace, superfluous whitespace and run stylize.php
* fix incorrect use of descriptionmsg in extension credits
Modified paths:
  • /trunk/extensions/Storyboard/StoryReview_body.php (modified) (history)
  • /trunk/extensions/Storyboard/Storyboard.alias.php (modified) (history)
  • /trunk/extensions/Storyboard/Storyboard.i18n.php (modified) (history)
  • /trunk/extensions/Storyboard/Storyboard.php (modified) (history)
  • /trunk/extensions/Storyboard/Storyboard_Settings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/StoryReview_body.php
@@ -1,28 +1,26 @@
22 <?php
3 -
4 -/**
 3+/**
54 * File holding the SpecialStoryReview class that allows reviewers to moderate the submitted stories.
65 *
76 * @file StoryReview_body.php
87 * @ingroup Storyboard
9 - *
 8+ *
109 * @author Jeroen De Dauw
1110 */
1211
13 -if( !defined( 'MEDIAWIKI' ) ) {
 12+if ( !defined( 'MEDIAWIKI' ) ) {
1413 die( 'Not an entry point.' );
1514 }
1615
1716 class SpecialStoryReview extends IncludableSpecialPage {
18 -
 17+
1918 function __construct() {
2019 parent::__construct( 'StoryReview' );
21 -
22 - wfLoadExtensionMessages( 'Storyboard' );
 20+
 21+ wfLoadExtensionMessages( 'Storyboard' );
2322 }
24 -
 23+
2524 function execute( $language ) {
2625 global $wgOut;
2726 }
28 -
29 -}
\ No newline at end of file
 27+}
Index: trunk/extensions/Storyboard/Storyboard.alias.php
@@ -1,5 +1,4 @@
22 <?php
3 -
43 /**
54 * Aliases for the special pages of the Storyboard extension.
65 *
@@ -16,4 +15,4 @@
1716 */
1817 $aliases['en'] = array(
1918 'StoryReview' => array( 'StoryReview' ),
20 -);
\ No newline at end of file
 19+);
Index: trunk/extensions/Storyboard/Storyboard.i18n.php
@@ -1,5 +1,4 @@
22 <?php
3 -
43 /**
54 * Internationalization file for the Storyboard extension.
65 *
@@ -16,6 +15,6 @@
1716 */
1817 $messages['en'] = array(
1918 // General
20 - 'storyboard_name' => 'Storyboard',
21 - 'storyboard_desc' => 'Provides a landing page for donors, a page where stories can be submitted, and a story moderation interface.',
22 -);
\ No newline at end of file
 19+ 'storyboard-name' => 'Storyboard',
 20+ 'storyboard-desc' => 'Provides a landing page for donors, a page where stories can be submitted, and a story moderation interface.',
 21+);
Index: trunk/extensions/Storyboard/Storyboard.php
@@ -1,12 +1,11 @@
22 <?php
3 -
4 -/**
 3+/**
54 * Initialization file for the Storyboard extension.
65 * Extension documentation: http://www.mediawiki.org/wiki/Extension:Storyboard
76 *
87 * @file Storyboard.php
98 * @ingroup Storyboard
10 - *
 9+ *
1110 * @author Jeroen De Dauw
1211 */
1312
@@ -14,24 +13,24 @@
1514 * This documenation group collects source code files belonging to Storyboard.
1615 *
1716 * Please do not use this group name for other code.
18 - *
 17+ *
1918 * @defgroup Storyboard Storyboard
2019 */
2120
22 -if( !defined( 'MEDIAWIKI' ) ) {
 21+if ( !defined( 'MEDIAWIKI' ) ) {
2322 die( 'Not an entry point.' );
2423 }
2524
26 -define('Storyboard_VERSION', '0');
 25+define( 'Storyboard_VERSION', '0' );
2726
28 -$egStoryboardScriptPath = $wgScriptPath . '/extensions/Storyboard';
29 -$egStoryboardDir = dirname( __FILE__ ) . '/';
 27+$egStoryboardScriptPath = $wgScriptPath . '/extensions/Storyboard';
 28+$egStoryboardDir = dirname( __FILE__ ) . '/';
3029
3130 // Include the settings file.
32 -require_once($egStoryboardDir . 'Storyboard_Settings.php');
 31+require_once( $egStoryboardDir . 'Storyboard_Settings.php' );
3332
3433 // Register the initialization function of Storyboard.
35 -$wgExtensionFunctions[] = 'efStoryboardSetup';
 34+$wgExtensionFunctions[] = 'efStoryboardSetup';
3635
3736 // Register the initernationalization and aliasing files of Storyboard.
3837 $wgExtensionMessagesFiles['Storyboard'] = $egStoryboardDir . 'Storyboard.i18n.php';
@@ -47,18 +46,16 @@
4847 */
4948 function efStoryboardSetup() {
5049 global $wgExtensionCredits;
51 -
52 - wfLoadExtensionMessages( 'Storyboard' );
53 -
 50+
 51+ wfLoadExtensionMessages( 'Storyboard' );
 52+
5453 $wgExtensionCredits['parserhook'][] = array(
5554 'path' => __FILE__,
56 - 'name' => wfMsg('storyboard_name'),
 55+ 'name' => wfMsg( 'storyboard-name' ),
5756 'version' => Storyboard_VERSION,
58 - 'author' => array('[http://bn2vs.com Jeroen De Dauw]'),
 57+ 'author' => array( '[http://bn2vs.com Jeroen De Dauw]' ),
5958 'url' => 'http://www.mediawiki.org/wiki/Extension:Storyboard',
60 - 'description' => wfMsg( 'storyboard_desc' ),
61 - 'descriptionmsg' => wfMsg( 'storyboard_desc' ),
 59+ 'description' => wfMsg( 'storyboard-desc' ),
 60+ 'descriptionmsg' => 'storyboard-desc',
6261 );
6362 }
64 -
65 -
Index: trunk/extensions/Storyboard/Storyboard_Settings.php
@@ -1,11 +1,10 @@
22 <?php
3 -
43 /**
54 * File defining the settings for the Storyboard extension.
65 * More info can be found at http://www.mediawiki.org/wiki/Extension:Storyboard
76 *
87 * NOTICE:
9 - * Changing one of these settings can be done by copieng or cutting it,
 8+ * Changing one of these settings can be done by copieng or cutting it,
109 * and placing it in LocalSettings.php, AFTER the inclusion of Storyboard.
1110 *
1211 * @file Storyboard_Settings.php
@@ -14,6 +13,6 @@
1514 * @author Jeroen De Dauw
1615 */
1716
18 -if( !defined( 'MEDIAWIKI' ) ) {
 17+if ( !defined( 'MEDIAWIKI' ) ) {
1918 die( 'Not an entry point.' );
20 -}
\ No newline at end of file
 19+}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62220Storyboard extensionjeroendedauw03:15, 10 February 2010

Status & tagging log