r61400 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61399‎ | r61400 | r61401 >
Date:21:59, 22 January 2010
Author:catrope
Status:deferred
Tags:
Comment:
ClickTracking: Hack up ClickTracking so it doesn't include JS on every pageview ever. This breaks tracking of non-usability things, but we're not doing that (any more)
Modified paths:
  • /trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php
@@ -60,7 +60,8 @@
6161 public static function addJS() {
6262 global $wgClickTrackingStyleVersion;
6363
64 - UsabilityInitiativeHooks::initialize();
 64+ // HACK: Only add scripts when they're really needed by not initializing UIH here
 65+ //UsabilityInitiativeHooks::initialize();
6566 UsabilityInitiativeHooks::addScript( 'ClickTracking/ClickTracking.js', $wgClickTrackingStyleVersion );
6667 UsabilityInitiativeHooks::addVariables(
6768 array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r61401wmf-deployment: Merge r61400 (ClickTracking fix) from trunkcatrope22:00, 22 January 2010

Status & tagging log