r61401 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61400‎ | r61401 | r61402 >
Date:22:00, 22 January 2010
Author:catrope
Status:ok
Tags:
Comment:
wmf-deployment: Merge r61400 (ClickTracking fix) from trunk
Modified paths:
  • /branches/wmf-deployment/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php
@@ -55,7 +55,8 @@
5656 public static function addJS() {
5757 global $wgClickTrackingStyleVersion;
5858
59 - UsabilityInitiativeHooks::initialize();
 59+ // HACK: Only add scripts when they're really needed by not initializing UIH here
 60+ //UsabilityInitiativeHooks::initialize();
6061 UsabilityInitiativeHooks::addScript( 'ClickTracking/ClickTracking.js', $wgClickTrackingStyleVersion );
6162 UsabilityInitiativeHooks::addVariables(
6263 array(
Property changes on: branches/wmf-deployment/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php
___________________________________________________________________
Name: svn:mergeinfo
6364 - /branches/REL1_15/phase3/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php:51646
/branches/usability/acaifix/ClickTracking/ClickTracking.hooks.php:59192-59203,59451-59464
/trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php:56151-57234,58926,58973-58974,59048,59202,59205,59212,59253
/trunk/phase3/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447,57541,57916,58151,58219,58633,58816
6465 + /branches/REL1_15/phase3/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php:51646
/branches/usability/acaifix/ClickTracking/ClickTracking.hooks.php:59192-59203,59451-59464
/trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php:56151-57234,58926,58973-58974,59048,59202,59205,59212,59253,61400
/trunk/phase3/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php:56213,56215-56216,56218,56325,56334-56336,56338,56340,56343,56345,56347,56350,57154-57447,57541,57916,58151,58219,58633,58816

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61400ClickTracking: Hack up ClickTracking so it doesn't include JS on every pagevi...catrope21:59, 22 January 2010

Status & tagging log