r61199 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61198‎ | r61199 | r61200 >
Date:12:56, 18 January 2010
Author:demon
Status:resolved
Tags:
Comment:
Add bug #
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/install-utils.inc (modified) (history)
  • /trunk/phase3/maintenance/syntaxChecker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/syntaxChecker.php
@@ -274,6 +274,7 @@
275275 $this->checkRegex( $file, $text, '/^[\s\r\n]+<\?/', 'leading whitespace' );
276276 $this->checkRegex( $file, $text, '/\?>[\s\r\n]*$/', 'trailing ?>' );
277277 $this->checkRegex( $file, $text, '/^[\xFF\xFE\xEF]/', 'byte-order mark' );
 278+ $this->checkRegex( $file, $text, '/\&\$this/', 'passing $this by reference' );
278279 }
279280
280281 private function checkRegex( $file, $text, $regex, $desc ) {
Index: trunk/phase3/maintenance/install-utils.inc
@@ -48,8 +48,9 @@
4949 call_user_func_array( array( $test, 'test' ), array( &$ok ) );
5050 if ( !$ok ) {
5151 echo "PHP " . phpversion() . " is not compatible with MediaWiki due to a bug involving\n" .
52 - "reference parameters to __call. Upgrade to PHP 5.3.2, or downgrade\n" .
53 - "to PHP 5.3.0. to fix this.\n" .
 52+ "reference parameters to __call in PHP versions 5.3.1, 5.2.12 and 5.2.11.\n" .
 53+ "Upgrade to PHP 5.3.2 (5.2.13 for 5.2 users), or downgrade\n" .
 54+ "to PHP 5.3.0 (5.2.10 for 5.2 users) to fix this.\n" .
5455 "ABORTING (see http://bugs.php.net/bug.php?id=50394 for details)\n";
5556 die( 1 );
5657 }
Index: trunk/phase3/RELEASE-NOTES
@@ -715,8 +715,8 @@
716716 skin-specific JS pages
717717 * (bug 5061) Use the more precise thumbcaption thumbimage and thumbinner classes
718718 for image divs.
719 -* IE50Fixes.css and IE55Fixes.css have been dropped from the Monobook and Chick
720 - skins
 719+* (bug 22096) IE50Fixes.css and IE55Fixes.css have been dropped from the Monobook
 720+ and Chick skins
721721
722722 == API changes in 1.16 ==
723723

Follow-up revisions

RevisionCommit summaryAuthorDate
r61200Fix stupid r61199, unrelated changes checkindemon13:02, 18 January 2010

Status & tagging log