r61200 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61199‎ | r61200 | r61201 >
Date:13:02, 18 January 2010
Author:demon
Status:ok
Tags:
Comment:
Fix stupid r61199, unrelated changes checkin
Modified paths:
  • /trunk/phase3/maintenance/install-utils.inc (modified) (history)
  • /trunk/phase3/maintenance/syntaxChecker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/syntaxChecker.php
@@ -274,7 +274,6 @@
275275 $this->checkRegex( $file, $text, '/^[\s\r\n]+<\?/', 'leading whitespace' );
276276 $this->checkRegex( $file, $text, '/\?>[\s\r\n]*$/', 'trailing ?>' );
277277 $this->checkRegex( $file, $text, '/^[\xFF\xFE\xEF]/', 'byte-order mark' );
278 - $this->checkRegex( $file, $text, '/\&\$this/', 'passing $this by reference' );
279278 }
280279
281280 private function checkRegex( $file, $text, $regex, $desc ) {
Index: trunk/phase3/maintenance/install-utils.inc
@@ -48,9 +48,8 @@
4949 call_user_func_array( array( $test, 'test' ), array( &$ok ) );
5050 if ( !$ok ) {
5151 echo "PHP " . phpversion() . " is not compatible with MediaWiki due to a bug involving\n" .
52 - "reference parameters to __call in PHP versions 5.3.1, 5.2.12 and 5.2.11.\n" .
53 - "Upgrade to PHP 5.3.2 (5.2.13 for 5.2 users), or downgrade\n" .
54 - "to PHP 5.3.0 (5.2.10 for 5.2 users) to fix this.\n" .
 52+ "reference parameters to __call. Upgrade to PHP 5.3.2, or downgrade\n" .
 53+ "to PHP 5.3.0. to fix this.\n" .
5554 "ABORTING (see http://bugs.php.net/bug.php?id=50394 for details)\n";
5655 die( 1 );
5756 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r61199Add bug #demon12:56, 18 January 2010

Status & tagging log