r61155 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61154‎ | r61155 | r61156 >
Date:00:18, 17 January 2010
Author:demon
Status:reverted (Comments)
Tags:
Comment:
(bug 22122) __call() bug check outputs incorrect version.
Modified paths:
  • /trunk/phase3/maintenance/install-utils.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/install-utils.inc
@@ -47,9 +47,9 @@
4848 $ok = false;
4949 call_user_func_array( array( $test, 'test' ), array( &$ok ) );
5050 if ( !$ok ) {
51 - echo "PHP 5.3.1 is not compatible with MediaWiki due to a bug involving\n" .
 51+ echo "PHP " . phpversion() . " is not compatible with MediaWiki due to a bug involving\n" .
5252 "reference parameters to __call. Upgrade to PHP 5.3.2, or downgrade\n" .
53 - "to PHP 5.3.0 to fix this.\n" .
 53+ "to PHP 5.3.0. to fix this.\n" .
5454 "ABORTING (see http://bugs.php.net/bug.php?id=50394 for details)\n";
5555 die( 1 );
5656 }

Comments

#Comment by Simetrical (talk | contribs)   23:09, 17 January 2010

This is possibly even more confusing. PHP 5.2.12 has a bug, so downgrade to 5.3.0? Probably better to list all affected versions.

#Comment by Reedy (talk | contribs)   13:40, 25 January 2010

Marking as reverted as Tim "fixed"/sorted this in r61480

Status & tagging log