r61085 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r61084‎ | r61085 | r61086 >
Date:14:37, 15 January 2010
Author:demon
Status:reverted (Comments)
Tags:
Comment:
And IE 5.5 too, while we're at it.
Modified paths:
  • /trunk/phase3/skins/Chick.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/chick/IE55Fixes.css (deleted) (history)
  • /trunk/phase3/skins/monobook/IE55Fixes.css (deleted) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/IE55Fixes.css
@@ -1,81 +0,0 @@
2 -/* IE5.5/win- only fixes */
3 -
4 -#column-content {
5 - float: none;
6 - margin-left: 0;
7 - height: 1%;
8 -}
9 -#column-content #content {
10 - position: relative;
11 - z-index: 5;
12 - margin-left: 12.2em;
13 - margin-top: 3em;
14 - height: 1%;
15 -}
16 -#column-one {
17 - position: absolute;
18 - top: 0;
19 - left: 0;
20 - z-index: 4;
21 - width: 100%;
22 -}
23 -#footer {
24 - margin-left: 13.6em;
25 - border-left: 1px solid #fabd23;
26 -}
27 -
28 -/*#bodyContent div,
29 -#bodyContent pre { overflow: auto; }*/
30 -
31 -#p-personal { padding-bottom: 0.1em; }
32 -
33 -body { font-size: xx-small; }
34 -
35 -#p-cactions {
36 - width: 76% !important;
37 - z-index: 3 !important;
38 - float: none;
39 -}
40 -#p-cactions li {
41 - padding-bottom: 0 !important;
42 - border: none;
43 - background-color: transparent;
44 - cursor: default;
45 - float: none !important;
46 -}
47 -#p-cactions li a {
48 - display: inline-block !important;
49 - vertical-align: top;
50 - padding-bottom: 0;
51 - border: solid #aaa;
52 - border-width: 1px 1px 0;
53 -}
54 -#p-cactions li.selected a {
55 - border-color: #fabd23;
56 - padding-bottom: 0.17em;
57 -}
58 -#p-cactions li a:hover {
59 - padding-bottom: 0.17em;
60 -}
61 -.portlet {
62 - overflow:hidden;
63 -}
64 -#bodyContent a.external {
65 - background: url(external.png) center right no-repeat;
66 - padding-right: 13px;
67 -}
68 -/* show the hand */
69 -#p-logo a,
70 -#p-logo a:hover {
71 - cursor: pointer;
72 -}
73 -.visualClear {
74 - width:90%;
75 - height: 1px;
76 - padding:0;
77 - margin:0;
78 -}
79 -
80 -#editform {
81 - width: 100%;
82 -}
Index: trunk/phase3/skins/monobook/IE55Fixes.css
@@ -1,85 +0,0 @@
2 -/* IE5.5/win- only fixes */
3 -
4 -#column-content {
5 - float: none;
6 - margin-left: 0;
7 - height: 1%;
8 -}
9 -#column-content #content {
10 - position: relative;
11 - z-index: 5;
12 - margin-left: 12.2em;
13 - margin-top: 3em;
14 - height: 1%;
15 -}
16 -#column-one {
17 - position: absolute;
18 - top: 0;
19 - left: 0;
20 - z-index: 4;
21 - width: 100%;
22 -}
23 -#footer {
24 - margin-left: 13.6em;
25 - border-left: 1px solid #fabd23;
26 -}
27 -
28 -/*#bodyContent div,
29 -#bodyContent pre { overflow: auto; }*/
30 -
31 -#p-personal { padding-bottom: .1em; }
32 -
33 -body { font-size: xx-small; }
34 -
35 -#p-cactions {
36 - width: 76% !important;
37 - z-index: 3 !important;
38 - float: none;
39 -}
40 -#p-cactions li {
41 - padding-bottom: 0 !important;
42 - border: none;
43 - background-color: transparent;
44 - cursor: default;
45 - float: none !important;
46 -}
47 -#p-cactions li a {
48 - display: inline-block !important;
49 - vertical-align: top;
50 - padding-bottom: 0;
51 - border: solid #aaa;
52 - border-width: 1px 1px 0;
53 -}
54 -#p-cactions li.selected a {
55 - border-color: #fabd23;
56 - padding-bottom: 0.17em;
57 -}
58 -#p-cactions li a:hover {
59 - padding-bottom: 0.17em;
60 -}
61 -#p-navigation a {
62 - display: inline-block;
63 - width: 100%;
64 -}
65 -.portlet {
66 - overflow: hidden;
67 -}
68 -#bodyContent a.external {
69 - background: url(external.png) center right no-repeat;
70 - padding-right: 13px;
71 -}
72 -/* show the hand */
73 -#p-logo a,
74 -#p-logo a:hover {
75 - cursor: pointer;
76 -}
77 -.visualClear {
78 - width: 90%;
79 - height: 1px;
80 - padding: 0;
81 - margin: 0;
82 -}
83 -
84 -#editform {
85 - width: 100%;
86 -}
Index: trunk/phase3/skins/Chick.php
@@ -25,7 +25,6 @@
2626 parent::setupSkinUserCss( $out );
2727 // Append to the default screen common & print styles...
2828 $out->addStyle( 'chick/main.css', 'screen,handheld' );
29 - $out->addStyle( 'chick/IE55Fixes.css', 'screen,handheld', 'IE 5.5000' );
3029 $out->addStyle( 'chick/IE60Fixes.css', 'screen,handheld', 'IE 6' );
3130 }
3231 }
Index: trunk/phase3/skins/MonoBook.php
@@ -35,12 +35,9 @@
3636 $out->addStyle( $wgHandheldStyle, 'handheld' );
3737 }
3838
39 - $out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );
4039 $out->addStyle( 'monobook/IE60Fixes.css', 'screen', 'IE 6' );
4140 $out->addStyle( 'monobook/IE70Fixes.css', 'screen', 'IE 7' );
42 -
4341 $out->addStyle( 'monobook/rtl.css', 'screen', '', 'rtl' );
44 -
4542 }
4643 }
4744

Follow-up revisions

RevisionCommit summaryAuthorDate
r62882Restore IE5/5.5 support to MonoBook and Chick...simetrical17:46, 23 February 2010
r62928Backport r62882, revert r61128...simetrical17:08, 24 February 2010

Comments

#Comment by Simetrical (talk | contribs)   17:47, 23 February 2010

Reverted in r62882, will backport to 1.16. See Code Review on r61083 for reasons.

Status & tagging log