r61083 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r61082‎ | r61083 | r61084 >
Date:14:26, 15 January 2010
Author:demon
Status:reverted (Comments)
Tags:
Comment:
Kill off IE50Fixes. Adds extra clutter to the head, and market share is down below 0.03% (http://is.gd/6jyWo).
Modified paths:
  • /trunk/phase3/skins/Chick.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/chick/IE50Fixes.css (deleted) (history)
  • /trunk/phase3/skins/monobook/IE50Fixes.css (deleted) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/IE50Fixes.css
——@@ -1,67 +0,0 @@
2 -/*
3 -** IE5.0 Fix Stylesheet
4 -*/
5 -
6 -#column-content {
7 - margin: 0 !important;
8 - float: none;
9 -}
10 -#column-content #content {
11 - margin-top: 3em;
12 - height: 1%;
13 -}
14 -#column-one {
15 - position: absolute;
16 - overflow: visible;
17 - top: 0;
18 - left: 0;
19 - z-index: 3;
20 -}
21 -#footer {
22 - margin: 0 0 0 13.6em;
23 -}
24 -
25 -/* IE 5 & 5.5 interpret keyword sizes one off */
26 -body { font-size: xx-small; }
27 -/*
28 -** the edit tabs
29 -*/
30 -#p-cactions li {
31 - float: left;
32 - padding-top: 0;
33 - padding-bottom: 0 !important;
34 - height: 0.9em;
35 -}
36 -#p-cactions li a {
37 - display: block;
38 - padding-bottom: 0.045em;
39 -}
40 -#p-cactions li.selected a {
41 - padding-bottom: 0.17em;
42 -}
43 -#p-cactions li a:hover {
44 - padding-bottom: 0.17em;
45 -}
46 -/* 5.0 doesn't like the background icon for external links and user */
47 -.link-external,
48 -.external {
49 - background: none;
50 - padding: 0;
51 -}
52 -#p-personal ul { float: right }
53 -#p-personal li { float: left }
54 -li#pt-userpage,
55 -li#pt-anonuserpage,
56 -li#pt-login,
57 -li#pt-logout {
58 - background: none;
59 - padding-left: none;
60 -}
61 -.visualClear {
62 - width:100%;
63 - height: 0px;
64 - padding:0;
65 - margin:0;
66 -}
67 -#firstHeading { margin-bottom: 0.3em; }
68 -/*div{ border:1px solid Red !important;}*/
Index: trunk/phase3/skins/monobook/IE50Fixes.css
——@@ -1,67 +0,0 @@
2 -/*
3 -** IE5.0 Fix Stylesheet
4 -*/
5 -
6 -#column-content {
7 - margin: 0 !important;
8 - float: none;
9 -}
10 -#column-content #content {
11 - margin-top: 3em;
12 - height: 1%;
13 -}
14 -#column-one {
15 - position: absolute;
16 - overflow: visible;
17 - top: 0;
18 - left: 0;
19 - z-index: 3;
20 -}
21 -#footer {
22 - margin: 0 0 0 13.6em;
23 -}
24 -
25 -/* IE 5 & 5.5 interpret keyword sizes one off */
26 -body { font-size: xx-small; }
27 -/*
28 -** the edit tabs
29 -*/
30 -#p-cactions li {
31 - float: left;
32 - padding-top: 0;
33 - padding-bottom: 0 !important;
34 - height: 0.9em;
35 -}
36 -#p-cactions li a {
37 - display: block;
38 - padding-bottom: 0.045em;
39 -}
40 -#p-cactions li.selected a {
41 - padding-bottom: 0.17em;
42 -}
43 -#p-cactions li a:hover {
44 - padding-bottom: 0.17em;
45 -}
46 -/* 5.0 doesn't like the background icon for external links and user */
47 -.link-external,
48 -.external {
49 - background: none;
50 - padding: 0;
51 -}
52 -#p-personal ul { float: right }
53 -#p-personal li { float: left }
54 -li#pt-userpage,
55 -li#pt-anonuserpage,
56 -li#pt-login,
57 -li#pt-logout {
58 - background: none;
59 - padding-left: none;
60 -}
61 -.visualClear {
62 - width: 100%;
63 - height: 0px;
64 - padding:0;
65 - margin: 0;
66 -}
67 -#firstHeading { margin-bottom: .3em; }
68 -/*div{ border:1px solid Red !important;}*/
Index: trunk/phase3/skins/Chick.php
——@@ -25,7 +25,6 @@
2626 parent::setupSkinUserCss( $out );
2727 // Append to the default screen common & print styles...
2828 $out->addStyle( 'chick/main.css', 'screen,handheld' );
29 - $out->addStyle( 'chick/IE50Fixes.css', 'screen,handheld', 'lt IE 5.5000' );
3029 $out->addStyle( 'chick/IE55Fixes.css', 'screen,handheld', 'IE 5.5000' );
3130 $out->addStyle( 'chick/IE60Fixes.css', 'screen,handheld', 'IE 6' );
3231 }
Index: trunk/phase3/skins/MonoBook.php
——@@ -35,7 +35,6 @@
3636 $out->addStyle( $wgHandheldStyle, 'handheld' );
3737 }
3838
39 - $out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
4039 $out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );
4140 $out->addStyle( 'monobook/IE60Fixes.css', 'screen', 'IE 6' );
4241 $out->addStyle( 'monobook/IE70Fixes.css', 'screen', 'IE 7' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r61128Followup r61083,r61084: add RELEASE-NOTES entrydemon15:35, 16 January 2010
r62882Restore IE5/5.5 support to MonoBook and Chick...simetrical17:46, 23 February 2010
r62928Backport r62882, revert r61128...simetrical17:08, 24 February 2010

Comments

#Comment by Platonides (talk | contribs)   15:04, 16 January 2010

I'm no fan of removing support for a browser if such support isn't currently giving us problems. But it sure needs an entry on RELEASE NOTES.

#Comment by 😂 (talk | contribs)   15:35, 16 January 2010

RELEASE-NOTES updated in r61128. I tested IE on OSX, and didn't notice any major regressions; adding this CSS didn't noticeably improve Monobook or Chick (I notice the other skins manage to avoid IE5 fix files, and they all display just fine (except Vector, but I don't think they ever targeted IE on Mac)

#Comment by Simetrical (talk | contribs)   17:48, 19 February 2010

I'd like to revert this. I agree with Gregory Maxwell and others in the wikitech-l thread:

http://lists.wikimedia.org/pipermail/wikitech-l/2010-January/046537.html

In absolute terms, 0.3% amounts to a lot of users. While this isn't enough for us to go out of our way to add support, we shouldn't remove existing support. I tested in IE5 (via ies4linux) and Monobook worked fine with the fixes, and was a total mess without them. I'm all for cutting down on <head> bloat, but not if it will make the site unusable for a significant number of people.

(According to our actual Squid stats, in November 2009 we got 6,816,000 hits from IE5, 5.01, or 5.5. Even granting that many of these are probably bots disguising themselves as IE, it's quite possibly thousands of people or more. Hard to say exactly – maybe we could look at requests for the stylesheet itself?)

Also, IE5 in OS X is a totally different browser from IE5 on Windows, which wasn't even loading these stylesheets to begin with, so of course there's no difference there.

#Comment by Simetrical (talk | contribs)   17:46, 23 February 2010

Reverted in r62882, will backport to 1.16.

Status & tagging log