r59907 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59906‎ | r59907 | r59908 >
Date:21:57, 9 December 2009
Author:tparscal
Status:resolved (Comments)
Tags:
Comment:
Removed the extra parameter from the attachEvent call, which only takes 2 parameters. This resolves issues in r59832.
Modified paths:
  • /trunk/phase3/skins/common/edit.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/edit.js
@@ -191,7 +191,7 @@
192192 editForm.addEventListener('focus', onfocus, true); // This MUST be true to work
193193 } else if ( editForm.attachEvent ) {
194194 // IE needs a specific trick here since it doesn't support the standard
195 - editForm.attachEvent( 'onfocusin', function() { onfocus(event); }, handler );
 195+ editForm.attachEvent( 'onfocusin', function() { onfocus(event); } );
196196 }
197197
198198 editForm

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59832Fixes for comments on r59655...dantman17:17, 8 December 2009

Comments

#Comment by Catrope (talk | contribs)   12:21, 10 December 2009

Needs $wgStyleVersion bump

#Comment by Bryan (talk | contribs)   21:21, 24 December 2009

Done in r60369.

Status & tagging log