r59906 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59905‎ | r59906 | r59907 >
Date:21:47, 9 December 2009
Author:ialex
Status:ok
Tags:
Comment:
* (bug 21803) Special:MyContributions now keeps the query string parameters
As side effect:
* Redirecting special pages now keep query string paramters set to "0" (e.g. for namespace)
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPage.php
@@ -858,7 +858,7 @@
859859 global $wgRequest;
860860 $params = array();
861861 foreach( $this->mAllowedRedirectParams as $arg ) {
862 - if( $val = $wgRequest->getVal( $arg, false ) )
 862+ if( ( $val = $wgRequest->getVal( $arg, null ) ) !== null )
863863 $params[] = $arg . '=' . $val;
864864 }
865865
@@ -965,6 +965,8 @@
966966 class SpecialMycontributions extends UnlistedSpecialPage {
967967 function __construct() {
968968 parent::__construct( 'Mycontributions' );
 969+ $this->mAllowedRedirectParams = array( 'limit', 'namespace', 'tagfilter',
 970+ 'offset', 'dir', 'year', 'month', 'feed' );
969971 }
970972
971973 function getRedirect( $subpage ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -674,6 +674,9 @@
675675 * (bug 20549) Parser tests were broken on SQLite backend
676676 * (bug 21776) Interwiki urls like http://en.wikibooks.org/wiki/cs: should give
677677 a redirect instead of a baderror.
 678+* (bug 21803) Special:MyContributions now keeps the query string parameters
 679+* Redirecting special pages now keep query string paramters set to "0" (e.g.
 680+ for namespace)
678681
679682 == API changes in 1.16 ==
680683

Status & tagging log