r59881 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59880‎ | r59881 | r59882 >
Date:13:02, 9 December 2009
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Modified paths:
  • /trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayersQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/OpenStreetMap/SM_OSMFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/OpenStreetMap/SM_OSMQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/QueryPrinters/SM_QueryPrinters.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsQP.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/YahooMaps/SM_YahooMapsQP.php
@@ -88,6 +88,9 @@
8989
9090 }
9191
 92+ /**
 93+ * Returns type info, descriptions and allowed values for this QP's parameters after adding the spesific ones to the list.
 94+ */
9295 public function getParameters() {
9396 $params = parent::getParameters();
9497
Index: trunk/extensions/SemanticMaps/OpenLayers/SM_OpenLayersQP.php
@@ -80,6 +80,9 @@
8181 /*]]>*/ </script>";
8282 }
8383
 84+ /**
 85+ * Returns type info, descriptions and allowed values for this QP's parameters after adding the spesific ones to the list.
 86+ */
8487 public function getParameters() {
8588 $params = parent::getParameters();
8689
Index: trunk/extensions/SemanticMaps/OpenStreetMap/SM_OSMQP.php
@@ -92,6 +92,9 @@
9393 EOT;
9494 }
9595
 96+ /**
 97+ * Returns type info, descriptions and allowed values for this QP's parameters after adding the spesific ones to the list.
 98+ */
9699 public function getParameters() {
97100 $params = parent::getParameters();
98101
Index: trunk/extensions/SemanticMaps/OpenStreetMap/SM_OSMFormInput.php
@@ -13,6 +13,8 @@
1414 die( 'Not an entry point.' );
1515 }
1616
 17+// TODO: the js for this form input does not work yet. Requires fixing before the FI can be enabled.
 18+
1719 final class SMOSMFormInput extends SMFormInput {
1820
1921 public $serviceName = MapsOSM::SERVICE_NAME;
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -25,7 +25,7 @@
2626
2727 // Only initialize the extension when all dependencies are present.
2828 if (defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' )) {
29 - define('SM_VERSION', '0.5 a19');
 29+ define('SM_VERSION', '0.5 a20');
3030
3131 $smgScriptPath = $wgScriptPath . '/extensions/SemanticMaps';
3232 $smgIP = $IP . '/extensions/SemanticMaps';
Index: trunk/extensions/SemanticMaps/QueryPrinters/SM_QueryPrinters.php
@@ -48,9 +48,16 @@
4949 }
5050
5151 private static function initializeParams() {
52 - global $egMapsDefaultServices, $egMapsDefaultCentre;
 52+ global $egMapsDefaultServices, $egMapsDefaultCentre, $egMapsAvailableGeoServices, $egMapsDefaultGeoService;
5353
5454 self::$parameters = array(
 55+ 'geoservice' => array(
 56+ 'aliases' => array(),
 57+ 'criteria' => array(
 58+ 'in_array' => array_keys($egMapsAvailableGeoServices)
 59+ ),
 60+ 'default' => $egMapsDefaultGeoService
 61+ ),
5562 'format' => array(
5663 'aliases' => array(),
5764 'criteria' => array(),
Index: trunk/extensions/SemanticMaps/GoogleMaps/SM_GoogleMapsQP.php
@@ -120,6 +120,9 @@
121121 $this->output .= $onloadFunctions;
122122 }
123123
 124+ /**
 125+ * Returns type info, descriptions and allowed values for this QP's parameters after adding the spesific ones to the list.
 126+ */
124127 public function getParameters() {
125128 $params = parent::getParameters();
126129

Status & tagging log