r59854 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59853‎ | r59854 | r59855 >
Date:22:28, 8 December 2009
Author:adam
Status:ok
Tags:
Comment:
Addressing Roan's comments on r59817 and r59812. Also adding a css rule to wikiEditor.toc.css to prevent the resize handles from rendering on top of dialog background overlays.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.i18n.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.toc.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -22,16 +22,16 @@
2323 array( 'src' => 'css/wikiEditor.css', 'version' => 7 ),
2424 array( 'src' => 'css/wikiEditor.toolbar.css', 'version' => 7 ),
2525 array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 5 ),
26 - array( 'src' => 'css/wikiEditor.toc.css', 'version' => 23 ),
 26+ array( 'src' => 'css/wikiEditor.toc.css', 'version' => 24 ),
2727 array( 'src' => 'css/wikiEditor.preview.css', 'version' => 1 ),
2828 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
2929 ),
3030 'combined' => array(
31 - array( 'src' => 'css/combined.css', 'version' => 33 ),
 31+ array( 'src' => 'css/combined.css', 'version' => 34 ),
3232 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3333 ),
3434 'minified' => array(
35 - array( 'src' => 'css/combined.min.css', 'version' => 33 ),
 35+ array( 'src' => 'css/combined.min.css', 'version' => 34 ),
3636 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3737 ),
3838 )
Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.toc.css
@@ -180,6 +180,7 @@
181181 left: -12px !important;
182182 cursor: ew-resize;
183183 background: url(../images/wikiEditor/toc/grip.png) 50% 50% no-repeat;
 184+ z-index: 0;
184185 }
185186 .wikiEditor-ui-toolbar .tab-toc {
186187 float: right;
Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -365,6 +365,7 @@
366366 left: -12px !important;
367367 cursor: ew-resize;
368368 background: url(../images/wikiEditor/toc/grip.png) 50% 50% no-repeat;
 369+ z-index: 0;
369370 }
370371 .wikiEditor-ui-toolbar .tab-toc {
371372 float: right;
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -341,6 +341,7 @@
342342 left:-12px !important;
343343 cursor:ew-resize;
344344 background:url(../images/wikiEditor/toc/grip.png) 50% 50% no-repeat;
 345+z-index:0;
345346 }
346347 .wikiEditor-ui-toolbar .tab-toc{
347348 float:right;
Index: trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.i18n.php
@@ -29,7 +29,7 @@
3030 'wikieditor-toolbar-tool-link' => 'Link',
3131 'wikieditor-toolbar-tool-link-title' => 'Insert link',
3232 'wikieditor-toolbar-tool-link-int' => 'To a wiki page',
33 - 'wikieditor-toolbar-tool-link-int-target' => 'Target Page or URL:',
 33+ 'wikieditor-toolbar-tool-link-int-target' => 'Target page or URL:',
3434 'wikieditor-toolbar-tool-link-int-target-tooltip' => 'Enter the page title',
3535 'wikieditor-toolbar-tool-link-int-text' => 'Displayed text:',
3636 'wikieditor-toolbar-tool-link-int-text-tooltip' => 'Enter the text that should be displayed',
Index: trunk/extensions/UsabilityInitiative/WikiEditor/Modules/Toolbar/Toolbar.js
@@ -891,8 +891,8 @@
892892 }
893893 if ( status == 'invalid' ) {
894894 $j( '.ui-dialog:visible .ui-dialog-buttonpane button:first' )
895 - .attr('disabled', true)
896 - .addClass('disabled');
 895+ .attr( 'disabled', true )
 896+ .addClass( 'disabled' );
897897 } else {
898898 $j( '.ui-dialog:visible .ui-dialog-buttonpane button:first' )
899899 .removeAttr('disabled')

Follow-up revisions

RevisionCommit summaryAuthorDate
r59860UsabilityInitiative: Fix stupid typo in r59809, recombine for r59854catrope23:45, 8 December 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59812Adding a disabling button to the insert link dialogadam00:30, 8 December 2009
r59817minor copy labeling change on the insert table dialogadam01:56, 8 December 2009

Status & tagging log