r59860 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59859‎ | r59860 | r59861 >
Date:23:45, 8 December 2009
Author:catrope
Status:ok
Tags:
Comment:
UsabilityInitiative: Fix stupid typo in r59809, recombine for r59854
Modified paths:
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php
@@ -17,7 +17,7 @@
1818 array( 'src' => 'Modules/Publish/Publish.js', 'version' => 2 ),
1919 array( 'src' => 'Modules/Toc/Toc.js', 'version' => 2 ),
2020 array( 'src' => 'Modules/Toolbar/Toolbar.js', 'version' => 14 ),
21 - array( 'src' => 'Modules/Toolbar/TemplateEditor.js', 'version' => 1 ),
 21+ array( 'src' => 'Modules/TemplateEditor/TemplateEditor.js', 'version' => 1 ),
2222 ),
2323 'combined' => array(
2424 array( 'src' => 'WikiEditor.combined.js', 'version' => 13 ),
Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.combined.js
@@ -939,8 +939,8 @@
940940 }
941941 if ( status == 'invalid' ) {
942942 $j( '.ui-dialog:visible .ui-dialog-buttonpane button:first' )
943 - .attr('disabled', true)
944 - .addClass('disabled');
 943+ .attr( 'disabled', true )
 944+ .addClass( 'disabled' );
945945 } else {
946946 $j( '.ui-dialog:visible .ui-dialog-buttonpane button:first' )
947947 .removeAttr('disabled')

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59809Created skeleton for "TemplateEditor" modulenimishg23:55, 7 December 2009
r59854Addressing Roan's comments on r59817 and r59812. Also adding a css rule to wi...adam22:28, 8 December 2009

Status & tagging log