r59363 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r59362‎ | r59363 | r59364 >
Date:19:16, 23 November 2009
Author:reedy
Status:resolved
Tags:
Comment:
Further followup to r59360

Add spellcheck to html5attribs for blacklisting

Switch from xml to html input
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)
  • /trunk/phase3/includes/Html.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1419,7 +1419,7 @@
14201420 Xml::tags( 'span', array( 'class' => $summaryClass, 'id' => "wpSummaryLabel" ),
14211421 $commentsubject );
14221422 $commentsubject .= ' ';
1423 - $commentsubject .= Xml::input( 'wpSummary',
 1423+ $commentsubject .= Html::input( 'wpSummary',
14241424 60,
14251425 $summarytext,
14261426 array(
@@ -1447,7 +1447,7 @@
14481448 $editsummary = Xml::tags( 'span', array( 'class' => $summaryClass, 'id' => "wpSummaryLabel" ),
14491449 $editsummary ) . ' ';
14501450
1451 - $editsummary .= Xml::input( 'wpSummary',
 1451+ $editsummary .= Html::input( 'wpSummary',
14521452 60,
14531453 $summarytext,
14541454 array(
Index: trunk/phase3/includes/Html.php
@@ -81,6 +81,7 @@
8282 'reversed',
8383 'scoped',
8484 'seamless',
 85+ 'spellcheck',
8586 );
8687
8788 /**
@@ -147,6 +148,7 @@
148149 'placeholder',
149150 'required',
150151 'step',
 152+ 'spellcheck',
151153 );
152154 foreach ( $html5attribs as $badAttr ) {
153155 unset( $attribs[$badAttr] );

Follow-up revisions

RevisionCommit summaryAuthorDate
r59385Followup r59363: Fix wrong syntax for Html::input. It accept other parameters...raymond17:31, 24 November 2009
r59963Fix bugs in r59360, r59361, r59363...simetrical19:01, 11 December 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59360bug 21604 Spellcheck attribute for editsummaryreedy18:38, 23 November 2009

Status & tagging log