r59360 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r59359‎ | r59360 | r59361 >
Date:18:38, 23 November 2009
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
bug 21604 Spellcheck attribute for editsummary
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
——@@ -1425,7 +1425,8 @@
14261426 array(
14271427 'id' => 'wpSummary',
14281428 'maxlength' => '200',
1429 - 'tabindex' => '1'
 1429+ 'tabindex' => '1',
 1430+ 'spellcheck' => 'yes'
14301431 ) );
14311432 } else {
14321433 $summaryhiddens .= Xml::hidden( 'wpIgnoreBlankSummary', true ); # bug 18699
——@@ -1452,7 +1453,8 @@
14531454 array(
14541455 'id' => 'wpSummary',
14551456 'maxlength' => '200',
1456 - 'tabindex' => '1'
 1457+ 'tabindex' => '1',
 1458+ 'spellcheck' => 'yes'
14571459 ) );
14581460
14591461 // No idea where this is closed.
Index: trunk/phase3/RELEASE-NOTES
——@@ -284,6 +284,7 @@
285285 * Added maintenance script syntaxChecker.php that checks for PHP syntax errors
286286 and common coding mistakes
287287 * Updated Unicode normalization tables
 288+* (bug 21604) Spellcheck attribute for editsummary
288289
289290 === Bug fixes in 1.16 ===
290291

Follow-up revisions

RevisionCommit summaryAuthorDate
r59361Minor followup for r59360...reedy18:52, 23 November 2009
r59363Further followup to r59360...reedy19:16, 23 November 2009
r59963Fix bugs in r59360, r59361, r59363...simetrical19:01, 11 December 2009

Comments

#Comment by Simetrical (talk | contribs)   19:02, 11 December 2009

Note that WebKit spellchecks in text inputs by default, so this doesn't affect it. On the other hand, though, if there are any text inputs that shouldn't be spellchecked, we might want to add spellcheck="false" to them for WebKit's sake.

Status & tagging log