r57775 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57774‎ | r57775 | r57776 >
Date:16:41, 15 October 2009
Author:catrope
Status:ok
Tags:
Comment:
Fix up r57706 to not show the warning at absolutely every edit page
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.js
@@ -24,7 +24,7 @@
2525 if(
2626 $j( '#wpTextbox1' ).data( 'origtext' ) != $j( '#wpTextbox1' ).val()
2727 || $j( '#wpSummary' ).data( 'origtext' ) != $j( '#wpSummary' ).val()
28 - || $j( '#wikiPreview' ).size() != 0
 28+ || $j( '#wikiPreview' ).is( ':visible' )
2929 ) {
3030 // Return our message
3131 return gM( 'editwarning-warning' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r57780wmf-deployment: Merge r57775 (fix for r57706) from trunkcatrope17:47, 15 October 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r57706EditWarning: Always pop up warning in preview; warning wouldn't get triggered...catrope16:50, 14 October 2009

Status & tagging log