r57706 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57705‎ | r57706 | r57707 >
Date:16:50, 14 October 2009
Author:catrope
Status:ok
Tags:
Comment:
EditWarning: Always pop up warning in preview; warning wouldn't get triggered if someone changes stuff, hits preview, then navigates away
Modified paths:
  • /trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.php
@@ -19,7 +19,7 @@
2020 /* Configuration */
2121
2222 // Bump the version number every time you change any of the .css/.js files
23 -$wgEditWarningStyleVersion = 3;
 23+$wgEditWarningStyleVersion = 4;
2424
2525 /* Setup */
2626
Index: trunk/extensions/UsabilityInitiative/EditWarning/EditWarning.js
@@ -24,6 +24,7 @@
2525 if(
2626 $j( '#wpTextbox1' ).data( 'origtext' ) != $j( '#wpTextbox1' ).val()
2727 || $j( '#wpSummary' ).data( 'origtext' ) != $j( '#wpSummary' ).val()
 28+ || $j( '#wikiPreview' ).size() != 0
2829 ) {
2930 // Return our message
3031 return gM( 'editwarning-warning' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r57719wmf-deployment: Merge babaco fixes from trunk...catrope20:20, 14 October 2009
r57775Fix up r57706 to not show the warning at absolutely every edit pagecatrope16:41, 15 October 2009
r57780wmf-deployment: Merge r57775 (fix for r57706) from trunkcatrope17:47, 15 October 2009

Status & tagging log