r57094 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r57093‎ | r57094 | r57095 >
Date:00:47, 30 September 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r56902 "(bug 18436) remove redundant (and disruptive to CSS) hardcoded "display:inline" style from messages injected with jsMsg()."
Totally broken; breaks at least Vector skin and any other which includes an initially-hidden div for the JS messages -- the div was no longer being unhidden.
Just use a !important in your custom style...
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
——@@ -940,6 +940,7 @@
941941 }
942942
943943 messageDiv.setAttribute( 'id', 'mw-js-message' );
 944+ messageDiv.style.display = 'block';
944945 if( className ) {
945946 messageDiv.setAttribute( 'class', 'mw-js-message-'+className );
946947 }
Index: trunk/phase3/RELEASE-NOTES
——@@ -530,8 +530,6 @@
531531 * (bug 20702) Parser functions can now be used correctly in
532532 MediaWiki:Missing-article
533533 * (bug 14117) "redirected from" is now also shown on foreign file redirects
534 -* (bug 18436) JavaScript-added AJAX messages (from the JS watch/unwatch, for
535 - instance) no longer include a redundant "display:block" hardcoded style.
536534 * (bug 20802) Fixed thumb.php redirect handling
537535 * (bug 17747) Only display thumbnail column in file history if the image can
538536 be rendered.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56902(bug 18436) remove redundant (and disruptive to CSS) hardcoded "display:inlin...happy-melon22:20, 24 September 2009

Status & tagging log