r57093 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57092‎ | r57093 | r57094 >
Date:00:38, 30 September 2009
Author:demon
Status:ok
Tags:
Comment:
Followup r56731, check for PHP 5.3 or greater (where it was fixed). Not a Windows issue
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
@@ -2326,9 +2326,12 @@
23272327 $cmd = escapeshellarg( $script ) . " $time $mem $filesize " . escapeshellarg( $cmd );
23282328 }
23292329 }
2330 - } elseif ( php_uname( 's' ) == 'Windows NT' && substr( php_uname( 'v' ), 6, 4 ) <= 6001 ) {
 2330+ } elseif ( php_uname( 's' ) == 'Windows NT' &&
 2331+ version_compare( PHP_VERSION, '5.3.0', '<' ) )
 2332+ {
23312333 # This is a hack to work around PHP's flawed invocation of cmd.exe
23322334 # http://news.php.net/php.internals/21796
 2335+ # Which is fixed in 5.3.0 :)
23332336 $cmd = '"' . $cmd . '"';
23342337 }
23352338 wfDebug( "wfShellExec: $cmd\n" );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56731(bug 20353) wfShellExec() malfunctioning on NT builds 6002 and above. Patch b...demon19:50, 21 September 2009

Status & tagging log