r56902 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56901‎ | r56902 | r56903 >
Date:22:20, 24 September 2009
Author:happy-melon
Status:reverted (Comments)
Tags:
Comment:
(bug 18436) remove redundant (and disruptive to CSS) hardcoded "display:inline" style from messages injected with jsMsg().
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/wikibits.js
@@ -940,7 +940,6 @@
941941 }
942942
943943 messageDiv.setAttribute( 'id', 'mw-js-message' );
944 - messageDiv.style.display = 'block';
945944 if( className ) {
946945 messageDiv.setAttribute( 'class', 'mw-js-message-'+className );
947946 }
Index: trunk/phase3/RELEASE-NOTES
@@ -536,6 +536,8 @@
537537 * (bug 20702) Parser functions can now be used correctly in
538538 MediaWiki:Missing-article
539539 * (bug 14117) "redirected from" is now also shown on foreign file redirects
 540+* (bug 18436) JavaScript-added AJAX messages (from the JS watch/unwatch, for
 541+ instance) no longer include a redundant "display:block" hardcoded style.
540542
541543 == API changes in 1.16 ==
542544

Follow-up revisions

RevisionCommit summaryAuthorDate
r57094Revert r56902 "(bug 18436) remove redundant (and disruptive to CSS) hardcoded...brion00:47, 30 September 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   00:38, 30 September 2009

This breaks in Vector; the div is initially hidden and now never gets unhidden.

Status & tagging log