r57091 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r57090‎ | r57091 | r57092 >
Date:23:16, 29 September 2009
Author:brion
Status:ok (Comments)
Tags:
Comment:
Revert r56635 "Implement a 'root' permission, which grants all other permissions. Useful for debugging and administration."
I'd much rather keep permission keys clean and separate.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1112,7 +1112,6 @@
11131113 'right-reset-passwords',
11141114 'right-override-export-depth',
11151115 'right-versiondetail',
1116 - 'right-root',
11171116 'right-sendemail',
11181117 ),
11191118 'rightslog' => array(
Index: trunk/phase3/includes/User.php
@@ -2154,8 +2154,7 @@
21552155 }
21562156 # Use strict parameter to avoid matching numeric 0 accidentally inserted
21572157 # by misconfiguration: 0 == 'foo'
2158 - return in_array( $action, $this->getRights(), true )
2159 - || in_array( 'root', $this->getRights(), true );
 2158+ return in_array( $action, $this->getRights(), true );
21602159 }
21612160
21622161 /**
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -1367,8 +1367,6 @@
13681368 'right-versiondetail' => '{{doc-right|versiondetail}}
13691369
13701370 Users having this right receive more detailed information on [[Special:Version]].',
1371 -'right-root' => "{{doc-right|root}}
1372 -Analogous to the 'root' permission on Unix systems, allows the user to perform ''any'' action on the wiki; effectively granting them all other permissions.",
13731371 'right-sendemail' => '{{doc-right}}',
13741372
13751373 # User rights log
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1932,7 +1932,6 @@
19331933 'right-reset-passwords' => "Reset other users' passwords",
19341934 'right-override-export-depth' => 'Export pages including linked pages up to a depth of 5',
19351935 'right-versiondetail' => 'Show the extended software version information',
1936 -'right-root' => 'Perform all actions on the wiki',
19371936 'right-sendemail' => 'Send e-mail to other users',
19381937
19391938 # User rights log
Index: trunk/phase3/RELEASE-NOTES
@@ -232,9 +232,6 @@
233233 $wgAJAXCategoriesNamespaces.
234234 * Admins could disable some variants using $wgDisabledVariants now. ONLY apply
235235 on wikis enabled LanguageConverter.
236 -* A new permission, 'root', is created. Analogous to root users on Unix
237 - systems, the root permission effectively grants all other permissions on a
238 - wiki. Useful for debugging and administration.
239236 * New configuration variable $wgShowPageOnRedlink that can be set to show the
240237 page instead of an edit interface when visiting a red link. The value can be
241238 specified for specific usergroups and namespaces.

Follow-up revisions

RevisionCommit summaryAuthorDate
r57092Follow-up r57091 (revert r56635): rebuild language filessiebrand23:19, 29 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56635Implement a 'root' permission, which grants all other permissions. Useful fo...happy-melon12:50, 19 September 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   17:58, 30 September 2009

Bug 20833 was an example of this 'root' permission causing trouble... you don't *want* to have every permission all the time!

Status & tagging log