r56635 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56634‎ | r56635 | r56636 >
Date:12:50, 19 September 2009
Author:happy-melon
Status:reverted (Comments)
Tags:
Comment:
Implement a 'root' permission, which grants all other permissions. Useful for debugging and administration.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1107,6 +1107,7 @@
11081108 'right-reset-passwords',
11091109 'right-override-export-depth',
11101110 'right-versiondetail',
 1111+ 'right-root',
11111112 ),
11121113 'rightslog' => array(
11131114 'rightslog',
Index: trunk/phase3/includes/User.php
@@ -2152,6 +2152,7 @@
21532153 # Use strict parameter to avoid matching numeric 0 accidentally inserted
21542154 # by misconfiguration: 0 == 'foo'
21552155 return in_array( $action, $this->getRights(), true )
 2156+ || in_array( 'root', $this->getRights(), true );
21562157 }
21572158
21582159 /**
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -1348,6 +1348,9 @@
13491349 'right-versiondetail' => '{{doc-right|versiondetail}}
13501350
13511351 Users having this right receive more detailed information on [[Special:Version]].',
 1352+'right-root' => '{{doc-right|root}}
 1353+Analogous to the \'root\' permission on Unix systems, allows the user to perform \'\'any\'\' action on the wiki; effectively granting them all other permissions.
 1354+',
13521355
13531356 # User rights log
13541357 'rightslog' => 'In [[Special:Log]]',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1042,7 +1042,7 @@
10431043 'login' => 'Log in',
10441044 'nav-login-createaccount' => 'Log in / create account',
10451045 'loginprompt' => 'You must have cookies enabled to log in to {{SITENAME}}.',
1046 -'userlogin' => 'Log in / create account',
 1046+'userlogin' => 'Log in',
10471047 'logout' => 'Log out',
10481048 'userlogout' => 'Log out',
10491049 'notloggedin' => 'Not logged in',
@@ -1090,6 +1090,7 @@
10911091 and you no longer wish to change it, you may ignore this message and
10921092 continue using your old password.',
10931093 'noemail' => 'There is no e-mail address recorded for user "$1".',
 1094+'noemailcreate' => 'You need to provide a valid email address',
10941095 'passwordsent' => 'A new password has been sent to the e-mail address registered for "$1".
10951096 Please log in again after you receive it.',
10961097 'blocked-mailpassword' => 'Your IP address is blocked from editing, and so is not allowed to use the password recovery function to prevent abuse.',
@@ -1926,6 +1927,7 @@
19271928 'right-reset-passwords' => "Reset other users' passwords",
19281929 'right-override-export-depth' => 'Export pages including linked pages up to a depth of 5',
19291930 'right-versiondetail' => 'Show the extended software version information',
 1931+'right-root' => 'Perform all actions on the wiki',
19301932
19311933 # User rights log
19321934 'rightslog' => 'User rights log',
Index: trunk/phase3/RELEASE-NOTES
@@ -230,6 +230,9 @@
231231 $wgAJAXCategoriesNamespaces.
232232 * Admins could disable some variants using $wgDisabledVariants now. ONLY apply on
233233 wikis enabled LanguageConverter.
 234+* A new permission, 'root', is created. Analogous to root users on Unix systems,
 235+ the root permission effectively grants all other permissions on a wiki. Useful
 236+ for debugging and administration.
234237
235238 === Bug fixes in 1.16 ===
236239

Follow-up revisions

RevisionCommit summaryAuthorDate
r56636Follow-up to r56635 - remove messages associated with Login rewrite that crep...happy-melon12:54, 19 September 2009
r57091Revert r56635 "Implement a 'root' permission, which grants all other permissi...brion23:16, 29 September 2009
r57092Follow-up r57091 (revert r56635): rebuild language filessiebrand23:19, 29 September 2009

Comments

#Comment by GerFes (talk | contribs)   09:26, 18 February 2011

зхлгеавролдж

Status & tagging log