r56713 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56712‎ | r56713 | r56714 >
Date:16:33, 21 September 2009
Author:brion
Status:ok
Tags:
Comment:
* (bug 20730) Fix to Special:Version ViewVC link for branch checkouts
Reverts r49997; link is now using the checkout revision which makes pathrev work properly again for branches, so we don't need to use the (apparently non-functional) revision parameter instead.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -477,12 +477,7 @@
478478 $info['url']
479479 );
480480 $pathRelativeToRepo = substr( $info['url'], strlen( $info['repo-url'] ) );
481 - if ( substr( $pathRelativeToRepo, 0, 6 ) == '/trunk' ) {
482 - $viewvc .= '/?pathrev=';
483 - } else {
484 - // Avoids 404 error using pathrev when it does not found
485 - $viewvc .= '/?revision=';
486 - }
 481+ $viewvc .= '/?pathrev=';
487482 $viewvc .= urlencode( $info['checkout-rev'] );
488483 $info['viewvc-url'] = $viewvc;
489484 }
Index: trunk/phase3/RELEASE-NOTES
@@ -521,6 +521,7 @@
522522 * (bug 20726) Title::getLatestRevID's documentation now says that the function
523523 returns false if the page doesn't exist
524524 * (bug 20751) ForeignApiRepo now urldecodes filenames when saving to local cache
 525+* (bug 20730) Fix to Special:Version ViewVC link for branch checkouts
525526
526527 == API changes in 1.16 ==
527528

Follow-up revisions

RevisionCommit summaryAuthorDate
r56714Merge r56713 from trunk -- fixlet for bug 20730 (Special:Version bad ViewVC v...brion16:35, 21 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r49997Follow up r49996, changing pathrev to revision on non-trunk preventing the 40...shinjiman06:01, 28 April 2009

Status & tagging log