r56714 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56713‎ | r56714 | r56715 >
Date:16:35, 21 September 2009
Author:brion
Status:ok
Tags:
Comment:
Merge r56713 from trunk -- fixlet for bug 20730 (Special:Version bad ViewVC version link for branch checkouts)
Modified paths:
  • /branches/wmf-deployment/includes/specials/SpecialVersion.php (modified) (history)

Diff [purge]

Index: branches/wmf-deployment/includes/specials/SpecialVersion.php
@@ -477,12 +477,7 @@
478478 $info['url']
479479 );
480480 $pathRelativeToRepo = substr( $info['url'], strlen( $info['repo-url'] ) );
481 - if ( substr( $pathRelativeToRepo, 0, 6 ) == '/trunk' ) {
482 - $viewvc .= '/?pathrev=';
483 - } else {
484 - // Avoids 404 error using pathrev when it does not found
485 - $viewvc .= '/?revision=';
486 - }
 481+ $viewvc .= '/?pathrev=';
487482 $viewvc .= urlencode( $info['checkout-rev'] );
488483 $info['viewvc-url'] = $viewvc;
489484 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56713* (bug 20730) Fix to Special:Version ViewVC link for branch checkouts...brion16:33, 21 September 2009

Status & tagging log