r56448 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56447‎ | r56448 | r56449 >
Date:21:38, 16 September 2009
Author:mrzman
Status:ok
Tags:
Comment:
use fetchUser statically per r56133
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUserrights.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUserrights.php
@@ -144,7 +144,7 @@
145145 function saveUserGroups( $username, $reason = '' ) {
146146 global $wgRequest, $wgUser, $wgGroupsAddToSelf, $wgGroupsRemoveFromSelf;
147147
148 - $user = $this->fetchUser( $username );
 148+ $user = self::fetchUser( $username );
149149 if( $user instanceof WikiErrorMsg ) {
150150 $wgOut->addWikiMsgArray( $user->getMessageKey(), $user->getMessageArgs() );
151151 return;
@@ -250,7 +250,7 @@
251251 function editUserGroupsForm( $username ) {
252252 global $wgOut;
253253
254 - $user = $this->fetchUser( $username );
 254+ $user = self::fetchUser( $username );
255255 if( $user instanceof WikiErrorMsg ) {
256256 $wgOut->addWikiMsgArray( $user->getMessageKey(), $user->getMessageArgs() );
257257 return;

Follow-up revisions

RevisionCommit summaryAuthorDate
r56450Merge r56447 and r56448: fixes needed for CentralAuth derived userrights modu...brion21:50, 16 September 2009
r56515Revert r56450 (encompassing r56447 and r56448) and r56133 on wmf-deployment. ...werdna14:30, 17 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56133API: Make it possible to fetch userrights tokens for interwiki users; make Us...catrope13:44, 10 September 2009

Status & tagging log