r56447 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r56446‎ | r56447 | r56448 >
Date:21:37, 16 September 2009
Author:mrzman
Status:resolved (Comments)
Tags:
Comment:
r56133 made fetchUser static
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialGlobalGroupMembership.php
——@@ -72,7 +72,7 @@
7373 }
7474 }
7575
76 - function fetchUser( $username ) {
 76+ static function fetchUser( $username ) {
7777 global $wgUser, $wgRequest;
7878
7979 $knownwiki = $wgRequest->getVal('wpKnownWiki');

Follow-up revisions

RevisionCommit summaryAuthorDate
r56450Merge r56447 and r56448: fixes needed for CentralAuth derived userrights modu...brion21:50, 16 September 2009
r56515Revert r56450 (encompassing r56447 and r56448) and r56133 on wmf-deployment. ...werdna14:30, 17 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56133API: Make it possible to fetch userrights tokens for interwiki users; make Us...catrope13:44, 10 September 2009

Comments

#Comment by Werdna (talk | contribs)   14:24, 17 September 2009

PHP does not have late static binding!

#Comment by Tim Starling (talk | contribs)   23:50, 1 December 2009

For the record, it was fixed in r56535.

Status & tagging log