r56323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r56322‎ | r56323 | r56324 >
Date:18:40, 14 September 2009
Author:emufarmers
Status:resolved (Comments)
Tags:
Comment:
Follow up to r56285: just grant all rights to the installer-created database user.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/users.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/users.sql
@@ -4,9 +4,9 @@
55 -- from local settings.
66 --
77
8 -GRANT DELETE,INSERT,SELECT,UPDATE,CREATE TEMPORARY TABLES,CREATE TABLE,ALTER TABLE ON `{$wgDBname}`.*
 8+GRANT * ON `{$wgDBname}`.*
99 TO '{$wgDBuser}'@'%' IDENTIFIED BY '{$wgDBpassword}';
10 -GRANT DELETE,INSERT,SELECT,UPDATE,CREATE TEMPORARY TABLES,CREATE TABLE,ALTER TABLE ON `{$wgDBname}`.*
 10+GRANT * ON `{$wgDBname}`.*
1111 TO '{$wgDBuser}'@localhost IDENTIFIED BY '{$wgDBpassword}';
12 -GRANT DELETE,INSERT,SELECT,UPDATE,CREATE TEMPORARY TABLES,CREATE TABLE,ALTER TABLE ON `{$wgDBname}`.*
 12+GRANT * ON `{$wgDBname}`.*
1313 TO '{$wgDBuser}'@localhost.localdomain IDENTIFIED BY '{$wgDBpassword}';
Index: trunk/phase3/RELEASE-NOTES
@@ -497,8 +497,8 @@
498498 * (bug 482) Don't include TOC in the printable version if it has been hidden
499499 * Adjust the time according to the user configuration on Special:Revisiondelete
500500 * (bug 20624) Installation no longer allows "qqq" as the chosen language
501 -* (bug 20634) The installer-created database user will now have CREATE TABLE
502 - and ALTER TABLE rights so that upgrades will go more smoothly.
 501+* (bug 20634) The installer-created database user will now have all rights on
 502+ the database so that upgrades will go more smoothly.
503503 * (bug 18180) Special:Export ignores limit, dir, offset parameters
504504
505505 == API changes in 1.16 ==

Follow-up revisions

RevisionCommit summaryAuthorDate
r56661Follow up to r56323: fix the broken grant syntax (which I should have tested ...emufarmers07:15, 20 September 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r56285(Bug 20634) Give the installer-created database user CREATE TABLE and ALTER T...emufarmers01:26, 14 September 2009

Comments

#Comment by Midom (talk | contribs)   06:57, 20 September 2009

what the heck were you smoking, this syntax doesn't exist on MySQL

Status & tagging log